[material-ui][TablePaginationActions] export TablePaginationActions as new component #46149
Conversation
sai6855
added
new feature
sai6855
changed the title
Netlify deploy preview
@mui/material/TablePaginationActions: parsed: +Infinity% , gzip: +Infinity% Bundle size reportDetails of bundle changes (Toolpad) |
…/material-ui into table-pagination-actions
There was a problem hiding this comment.
@sai6855 Well done.
My last request, can you turn the root div in TablePaginationActions to a styled component, so that it is themable? It's for consistency with other components
const Root = styled('div', {
name: 'MuiTablePaginationActions',
slot: 'Root',
})Also, need to update several files related to theme components types.
…/material-ui into table-pagination-actions
There was a problem hiding this comment.
@siriwatknp converted component to styled component and added component to theme files wherever applicable. This PR is ready for review now
| classes, | ||
| muiName: 'MuiTablePaginationActions', | ||
| refInstanceof: window.HTMLDivElement, | ||
| skip: ['componentsProp', 'componentProp', 'themeVariants'], |
There was a problem hiding this comment.
Removed classesRoot, themeDefaultProps, and themeStyleOverrides. This test serves as proof that applying the root class and setting props from the theme are working correctly.
| { | ||
| createTheme({ | ||
| components: { | ||
| MuiTablePaginationActions: { |
There was a problem hiding this comment.
ts test for presence of MuiTablePaginationActions in theme
closes #46140
Api docs: https://deploy-preview-46149--material-ui.netlify.app/material-ui/api/table-pagination-actions/
Now users can do
import {TablePaginationActionsProps} from @mui/material/TablePaginationAction, proof: https://stackblitz.com/edit/ueff8vmm?file=src%2FDemo.tsx