[material-ui][Chip] Fix handling on event handlers #46263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
component: chip
Netlify deploy previewhttps://deploy-preview-46263--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
commented
Jun 3, 2025
| chip.focus(); | ||
| }); | ||
|
|
||
| fireEvent.keyDown(chip, { key: 'Enter' }); |
There was a problem hiding this comment.
As keyDown can't be fired on non-focusable elements, i converted Chip to button by adding onClick={()=>{}} and then fired keyDown event
siriwatknp
approved these changes
Jun 4, 2025
1 task
mj12albert
pushed a commit
to mj12albert/material-ui
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46262
fixes #46360
preview: https://deploy-preview-46263--material-ui.netlify.app/material-ui/react-chip/