[docs] Fix the keyboard navigation in GroupedMenu example#47842
Merged
silviuaavram merged 3 commits intomui:masterfrom Feb 24, 2026
Merged
[docs] Fix the keyboard navigation in GroupedMenu example#47842silviuaavram merged 3 commits intomui:masterfrom
silviuaavram merged 3 commits intomui:masterfrom
Conversation
silviuaavram
added
docs
Netlify deploy previewhttps://deploy-preview-47842--material-ui.netlify.app/ Bundle size report
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Material UI docs “GroupedMenu” example to ensure correct keyboard navigation by preventing non-selectable list headers from being treated as highlightable menu items.
Changes:
- Adds
muiSkipListHighlight: trueto the styledListSubheaderwrapper soMenuListskips it during keyboard navigation. - Adds an inline comment explaining why the skip flag is required.
- Applies the same update to both the TS and JS versions of the example.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/data/material/components/menus/GroupedMenu.tsx | Attaches muiSkipListHighlight to the styled ListSubheader wrapper and documents the intent. |
| docs/data/material/components/menus/GroupedMenu.js | Mirrors the TS change for the JS docs example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
siriwatknp
approved these changes
Feb 24, 2026
ZeeshanTamboli
approved these changes
Feb 24, 2026
|
Cherry-pick PRs will be created targeting branches: v7.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this property will fix the keyboard navigation for the example, by intentionally skipping non-focusable items. Also added a comment explaining why.
Preview: https://deploy-preview-47842--material-ui.netlify.app/material-ui/react-menu/#grouped-menu