Skip to content

[test] Add screenshot test for Virtualized Table #47947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mj12albert merged 8 commits into from
Mar 30, 2026
Merged

[test] Add screenshot test for Virtualized Table #47947

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
099d351
[test] Add screenshot test for Virtualized Table
mnajdova Mar 11, 2026
9306746
fix test
mnajdova Mar 11, 2026
8df3dd4
prettier
mnajdova Mar 11, 2026
8b0d030
fix path
mnajdova Mar 11, 2026
522f134
add only one screenshot
mnajdova Mar 11, 2026
0f949c2
reuse the docs one
mnajdova Mar 11, 2026
3e0f252
Jan's suggestion
mnajdova Mar 11, 2026
7b4fa96
Remove not needed dependencies
mnajdova Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"@types/react-is": "19.2.0",
"@types/sinon": "17.0.4",
"chai": "6.2.2",
"chance": "^1.1.13",
"docs": "workspace:^",
"es-toolkit": "1.44.0",
"fast-glob": "3.3.3",
Expand All @@ -30,6 +31,7 @@
"react-dom": "19.2.4",
"react-is": "19.2.4",
"react-router": "7.13.1",
"react-virtuoso": "^4.18.1",
"react-window": "2.2.7",
"sinon": "21.0.1",
"styled-components": "6.3.11",
Expand Down
1 change: 0 additions & 1 deletion test/regressions/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ const importDemos = import.meta.glob(
'!docs/data/material/components/stack/InteractiveStack', // Redundant
'!docs/data/material/components/steppers/HorizontalNonLinearStepper', // Redundant
'!docs/data/material/components/steppers/TextMobileStepper', // Flaky image loading
'!docs/data/material/components/table/ReactVirtualizedTable', // Flaky
'!docs/data/material/components/tabs/AccessibleTabs1', // Need interaction
'!docs/data/material/components/tabs/AccessibleTabs2', // Need interaction
'!docs/data/material/components/textarea-autosize', // Superseded by a dedicated regression test
Expand Down
9 changes: 9 additions & 0 deletions test/regressions/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,15 @@ async function main() {
});
});

describe('Table', () => {
it('should integrate with react-virtuoso', async () => {
Comment thread
mnajdova marked this conversation as resolved.
Outdated
const testcase = await renderFixture('/docs-components-table/ReactVirtualizedTable');
await page.waitForSelector('[data-index="1"]');
// Override the existing screenshot with the one after the rows have loaded to avoid flakiness during loading
await takeScreenshot({ testcase, route: '/docs-components-table/ReactVirtualizedTable' });
});
});

describe('Textarea', () => {
it('should keep input caret position at the end when adding a newline', async () => {
await renderFixture('/regression-Textarea/TextareaAutosize');
Expand Down
Loading