-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[typography] remove deprecated props #47986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b9ebbaf
remove deprecated props
siriwatknp 4eecca4
move Typography to Deprecated APIs removed section, fix codemod tag
siriwatknp 26faaf0
Apply suggestion from @siriwatknp
siriwatknp b666cbd
update doc
siriwatknp 607e4cd
Merge branch 'master' of github.com:mui/material-ui into remove-dep-t…
siriwatknp 69756de
update doc
siriwatknp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -184,6 +184,23 @@ If you were using `MuiTouchRipple` in your theme, remove it and use global CSS w | |
| }); | ||
| ``` | ||
|
|
||
| ### Typography | ||
|
|
||
| #### Deprecated props removed | ||
|
|
||
| The deprecated `paragraph` prop and `typographyClasses.paragraph` have been removed. | ||
|
|
||
| Migrate to `component` prop with the codemod below: | ||
|
|
||
| ```bash | ||
| npx @mui/codemod@next deprecations/typography-props <path> | ||
| ``` | ||
|
|
||
| ```diff | ||
| - <Typography paragraph>Hello</Typography> | ||
| + <Typography component="p" sx={{ mb: 2 }}>Hello</Typography> | ||
| ``` | ||
|
|
||
| ### JSDOM support | ||
|
|
||
| v9 removes all usage of `process.env.NODE_ENV === 'test'`. The `NODE_ENV` variable will exclusively be used for for tree-shaking. Our libraries have been updated to auto-detect DOM environments that don't support layout such as [JSDOM](https://github.com/jsdom/jsdom) and [happy-dom](https://github.com/capricorn86/happy-dom) through user agent sniffing. | ||
|
|
@@ -471,3 +488,18 @@ If you render a `TextField` from `Autocomplete`, the `params` shape also changed | |
| )} | ||
| /> | ||
| ``` | ||
|
|
||
| #### Typography deprecated props removed | ||
|
|
||
| Use the [typography-props codemod](https://github.com/mui/material-ui/tree/HEAD/packages/mui-codemod#typography-props) below to migrate the code as described in the following section: | ||
|
|
||
| ```bash | ||
| npx @mui/codemod@latest deprecations/typography-props <path> | ||
| ``` | ||
|
|
||
| The deprecated `paragraph` prop and `typographyClasses.paragraph` have been removed. | ||
|
|
||
| ```diff | ||
| - <Typography paragraph>Hello</Typography> | ||
| + <Typography component="p" sx={{ mb: 2 }}>Hello</Typography> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need to show something for the removed
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. true. Let me add it. |
||
| ``` | ||
|
siriwatknp marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.