Skip to content

[circularprogress] Remove deprecated classes#48014

Merged
silviuaavram merged 9 commits intomui:masterfrom
silviuaavram:chore/remove-deprecated-props-8
Mar 19, 2026
Merged

[circularprogress] Remove deprecated classes#48014
silviuaavram merged 9 commits intomui:masterfrom
silviuaavram:chore/remove-deprecated-props-8

Conversation

@silviuaavram
Copy link
Copy Markdown
Member

@silviuaavram silviuaavram commented Mar 17, 2026

@silviuaavram silviuaavram added breaking change Introduces changes that are not backward compatible. component: CircularProgress The React component. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. v9.x labels Mar 17, 2026
@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 17, 2026

Netlify deploy preview

Bundle size report

Bundle Parsed size Gzip size
@mui/material ▼-85B(-0.02%) ▼-22B(-0.02%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 7dff4e3

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes deprecated CircularProgress CSS utility classes (circleDeterminate, circleIndeterminate) across the Material UI source and documentation, and updates tests/migration guidance to rely on the non-deprecated class combinations.

Changes:

  • Removed deprecated class keys from circularProgressClasses and stopped generating/applying them in CircularProgress.
  • Updated unit tests to assert indeterminate on the root and circle on the <circle> element.
  • Updated API docs JSON and added an Upgrade-to-v9 migration note for the removed classes.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/mui-material/src/CircularProgress/circularProgressClasses.ts Removes deprecated class keys from the public classes interface and generated utility classes.
packages/mui-material/src/CircularProgress/CircularProgress.js Stops composing/applying the deprecated variant-specific circle classes and removes them from the overrides resolver.
packages/mui-material/src/CircularProgress/CircularProgress.test.js Updates assertions to match the new class strategy (indeterminate on root, circle on circle).
docs/translations/api-docs/circular-progress/circular-progress.json Removes deprecated class entries from translated API docs content.
docs/pages/material-ui/api/circular-progress.json Removes deprecated class entries from the API documentation data.
docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md Adds a v9 upgrade note describing the removed classes and suggested replacements/codemod.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md Outdated
@silviuaavram silviuaavram force-pushed the chore/remove-deprecated-props-8 branch from caec2d5 to c166ac9 Compare March 18, 2026 09:11
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 18, 2026
@silviuaavram silviuaavram force-pushed the chore/remove-deprecated-props-8 branch from c166ac9 to bdbbb73 Compare March 18, 2026 13:06
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 18, 2026
@silviuaavram
Copy link
Copy Markdown
Member Author

For now, in the codemod, the actual.js looks like this:

import { circularProgressClasses } from '@mui/material/CircularProgress';

('& .MuiCircularProgress-circleDeterminate');
('& .MuiCircularProgress-circleIndeterminate');
`& .${circularProgressClasses.circleDeterminate}`;
`& .${circularProgressClasses.circleIndeterminate}`;

Last 2 entries won't work anymore, because we are removing those classes. How are we changing the codemod in this case?

@ZeeshanTamboli @siriwatknp @mj12albert

@zannager zannager added the scope: progress Changes related to the progress. label Mar 18, 2026
Comment thread packages/mui-codemod/README.md Outdated
Comment thread packages/mui-codemod/README.md Outdated
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 19, 2026
@silviuaavram silviuaavram force-pushed the chore/remove-deprecated-props-8 branch from 0fa7c17 to 756e230 Compare March 19, 2026 09:26
@github-actions github-actions Bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Mar 19, 2026
@silviuaavram silviuaavram force-pushed the chore/remove-deprecated-props-8 branch from 9d5c876 to 558e33d Compare March 19, 2026 09:57
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 19, 2026
@silviuaavram silviuaavram merged commit 4ed05ff into mui:master Mar 19, 2026
23 checks passed
@silviuaavram silviuaavram deleted the chore/remove-deprecated-props-8 branch March 19, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. component: CircularProgress The React component. scope: progress Changes related to the progress. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. v9.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants