[circularprogress] Remove deprecated classes#48014
Merged
silviuaavram merged 9 commits intomui:masterfrom Mar 19, 2026
Merged
Conversation
49 tasks
Netlify deploy previewBundle size report
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes deprecated CircularProgress CSS utility classes (circleDeterminate, circleIndeterminate) across the Material UI source and documentation, and updates tests/migration guidance to rely on the non-deprecated class combinations.
Changes:
- Removed deprecated class keys from
circularProgressClassesand stopped generating/applying them inCircularProgress. - Updated unit tests to assert
indeterminateon the root andcircleon the<circle>element. - Updated API docs JSON and added an Upgrade-to-v9 migration note for the removed classes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/mui-material/src/CircularProgress/circularProgressClasses.ts | Removes deprecated class keys from the public classes interface and generated utility classes. |
| packages/mui-material/src/CircularProgress/CircularProgress.js | Stops composing/applying the deprecated variant-specific circle classes and removes them from the overrides resolver. |
| packages/mui-material/src/CircularProgress/CircularProgress.test.js | Updates assertions to match the new class strategy (indeterminate on root, circle on circle). |
| docs/translations/api-docs/circular-progress/circular-progress.json | Removes deprecated class entries from translated API docs content. |
| docs/pages/material-ui/api/circular-progress.json | Removes deprecated class entries from the API documentation data. |
| docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md | Adds a v9 upgrade note describing the removed classes and suggested replacements/codemod. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
mnajdova
approved these changes
Mar 17, 2026
caec2d5 to
c166ac9
Compare
silviuaavram
commented
Mar 18, 2026
mj12albert
reviewed
Mar 18, 2026
c166ac9 to
bdbbb73
Compare
Member
Author
|
For now, in the codemod, the actual.js looks like this: import { circularProgressClasses } from '@mui/material/CircularProgress';
('& .MuiCircularProgress-circleDeterminate');
('& .MuiCircularProgress-circleIndeterminate');
`& .${circularProgressClasses.circleDeterminate}`;
`& .${circularProgressClasses.circleIndeterminate}`;Last 2 entries won't work anymore, because we are removing those classes. How are we changing the codemod in this case? |
mj12albert
reviewed
Mar 18, 2026
mj12albert
reviewed
Mar 18, 2026
0fa7c17 to
756e230
Compare
9d5c876 to
558e33d
Compare
siriwatknp
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.