Skip to content

[dialog][modal][drawer][swipeabledrawer] Remove deprecated props and classes#48039

Merged
silviuaavram merged 5 commits intomui:masterfrom
silviuaavram:chore/remove-deprecated-props-9
Mar 23, 2026
Merged

[dialog][modal][drawer][swipeabledrawer] Remove deprecated props and classes#48039
silviuaavram merged 5 commits intomui:masterfrom
silviuaavram:chore/remove-deprecated-props-9

Conversation

@silviuaavram
Copy link
Copy Markdown
Member

@silviuaavram silviuaavram commented Mar 19, 2026

Copilot AI review requested due to automatic review settings March 19, 2026 08:57
@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 19, 2026

Netlify deploy preview

Bundle size report

Bundle Parsed size Gzip size
@mui/material ▼-599B(-0.12%) ▼-296B(-0.20%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 5c54669

@silviuaavram silviuaavram added breaking change Introduces changes that are not backward compatible. scope: dialog Changes related to the dialog. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. v9.x labels Mar 19, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the removal of deprecated Dialog props and composed CSS classes, aligning the component API and styling hooks with the slots/slotProps pattern and updated class composition expected for the v9 upgrade path.

Changes:

  • Removed deprecated Dialog props: PaperProps, TransitionComponent, and TransitionProps in favor of slotProps.paper, slots.transition, and slotProps.transition.
  • Removed deprecated composed CSS utility classes paperScrollPaper / paperScrollBody and updated internal styling/tests/docs to use selectors based on .MuiDialog-scroll* > .MuiDialog-paper.
  • Updated API docs, translations, and the v9 upgrade guide with migration instructions and codemod references.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/mui-material/src/Dialog/dialogClasses.ts Drops deprecated paperScroll* utility class keys from the public DialogClasses contract.
packages/mui-material/src/Dialog/Dialog.js Removes legacy prop handling and composed paper scroll class generation; keeps slot-based defaults (e.g., default transition via useSlot).
packages/mui-material/src/Dialog/Dialog.d.ts Removes deprecated prop types to match the new public API surface.
packages/mui-material/src/Dialog/Dialog.test.js Updates tests to assert the new class composition and slot-based transition/paper props usage.
packages/mui-material/src/Dialog/Dialog.spec.tsx Updates TS usage example from PaperProps to slotProps.paper.
docs/pages/material-ui/api/dialog.json Removes deprecated prop/class entries from generated API documentation data.
docs/translations/api-docs/dialog/dialog.json Removes deprecated prop/class entries from translated API docs data.
docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md Adds explicit v9 migration guidance and codemod commands for removed Dialog props/classes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 19, 2026
@silviuaavram silviuaavram changed the title [dialog] Remove deprecated props and classes [dialog][modal][drawer][swipeabledrawer] Remove deprecated props and classes Mar 19, 2026
@silviuaavram silviuaavram force-pushed the chore/remove-deprecated-props-9 branch from aa990c9 to 4f086d7 Compare March 19, 2026 13:34
@github-actions github-actions Bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Mar 19, 2026
@silviuaavram silviuaavram force-pushed the chore/remove-deprecated-props-9 branch from 98bc0e0 to 6004125 Compare March 19, 2026 14:14
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 19, 2026
@silviuaavram silviuaavram added scope: drawer Changes related to the drawer. scope: modal Changes related to the modal. labels Mar 19, 2026
Comment thread packages/mui-material/src/Dialog/Dialog.js
Comment thread packages/mui-material/src/Drawer/Drawer.js
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 20, 2026
@silviuaavram silviuaavram force-pushed the chore/remove-deprecated-props-9 branch from 65235c1 to d27fb5c Compare March 20, 2026 13:00
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 20, 2026
Comment thread packages/mui-material/src/Modal/Modal.js
Comment thread packages/mui-material/src/Modal/Modal.js
Comment thread packages/mui-material/src/Modal/Modal.js
Comment thread packages/mui-material/src/SwipeableDrawer/SwipeableDrawer.js
Comment thread packages/mui-material/src/SwipeableDrawer/SwipeableDrawer.js
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 23, 2026
siriwatknp

This comment was marked as duplicate.

Copy link
Copy Markdown
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! A few inline nits.

Comment thread packages/mui-material/src/Drawer/Drawer.js
Comment thread docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md
Comment thread docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md
Comment thread packages/mui-material/src/Drawer/Drawer.js Outdated
Copy link
Copy Markdown
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 please address my suggestion.

@silviuaavram silviuaavram force-pushed the chore/remove-deprecated-props-9 branch from af1b0f7 to a41e93a Compare March 23, 2026 10:06
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 23, 2026
Copy link
Copy Markdown
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siriwatknp siriwatknp dismissed their stale review March 23, 2026 11:12

already checked and it's does not impact the behavior change

Copy link
Copy Markdown
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@silviuaavram silviuaavram merged commit 1da1624 into mui:master Mar 23, 2026
23 checks passed
@silviuaavram silviuaavram deleted the chore/remove-deprecated-props-9 branch March 23, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. scope: dialog Changes related to the dialog. scope: drawer Changes related to the drawer. scope: modal Changes related to the modal. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. v9.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants