[dialog][modal][drawer][swipeabledrawer] Remove deprecated props and classes#48039
Conversation
Netlify deploy previewBundle size report
|
There was a problem hiding this comment.
Pull request overview
This PR completes the removal of deprecated Dialog props and composed CSS classes, aligning the component API and styling hooks with the slots/slotProps pattern and updated class composition expected for the v9 upgrade path.
Changes:
- Removed deprecated
Dialogprops:PaperProps,TransitionComponent, andTransitionPropsin favor ofslotProps.paper,slots.transition, andslotProps.transition. - Removed deprecated composed CSS utility classes
paperScrollPaper/paperScrollBodyand updated internal styling/tests/docs to use selectors based on.MuiDialog-scroll* > .MuiDialog-paper. - Updated API docs, translations, and the v9 upgrade guide with migration instructions and codemod references.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/mui-material/src/Dialog/dialogClasses.ts | Drops deprecated paperScroll* utility class keys from the public DialogClasses contract. |
| packages/mui-material/src/Dialog/Dialog.js | Removes legacy prop handling and composed paper scroll class generation; keeps slot-based defaults (e.g., default transition via useSlot). |
| packages/mui-material/src/Dialog/Dialog.d.ts | Removes deprecated prop types to match the new public API surface. |
| packages/mui-material/src/Dialog/Dialog.test.js | Updates tests to assert the new class composition and slot-based transition/paper props usage. |
| packages/mui-material/src/Dialog/Dialog.spec.tsx | Updates TS usage example from PaperProps to slotProps.paper. |
| docs/pages/material-ui/api/dialog.json | Removes deprecated prop/class entries from generated API documentation data. |
| docs/translations/api-docs/dialog/dialog.json | Removes deprecated prop/class entries from translated API docs data. |
| docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md | Adds explicit v9 migration guidance and codemod commands for removed Dialog props/classes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
aa990c9 to
4f086d7
Compare
98bc0e0 to
6004125
Compare
65235c1 to
d27fb5c
Compare
siriwatknp
left a comment
There was a problem hiding this comment.
Nice cleanup! A few inline nits.
siriwatknp
left a comment
There was a problem hiding this comment.
👍 please address my suggestion.
af1b0f7 to
a41e93a
Compare
siriwatknp
left a comment
There was a problem hiding this comment.
please check Albert's comment on https://github.com/mui/material-ui/pull/48039/changes#r2968008623
already checked and it's does not impact the behavior change
Try it here: https://stackblitz.com/edit/98gzfnl6?file=src%2FDemo.tsx