[DatePicker] Made sure we don't close the date picker when switching months with the autoOk prop set to true#830
Closed
matias-sandell wants to merge 2 commits into
Closed
[DatePicker] Made sure we don't close the date picker when switching months with the autoOk prop set to true#830matias-sandell wants to merge 2 commits into
matias-sandell wants to merge 2 commits into
Conversation
Added isNavigation to _setSelectedDate() to make sure we don't close the datepicker when navigating and not picking
Added isNavigation to _onSelectedDate() to make sure we don't close the date picker when switching months with the autoOk prop set to true.
Member
|
Yeh, I'm not even sure why e is needed for _setSelectedDate. Also, it might be better to just expose the onDayTouchTap in the calendar component instead of keeping track of navigation events? That way dialog window can bind to it and close itself. Thanks @matiaslarsson |
Contributor
Author
|
OK @hai-cea, will have a look when I get back from my vacation and create a new PR if I can. |
|
Was just going to fix this myself and decided to check if anyone was working on it! Thanks for fixing it! |
hai-cea
changed the title
Contributor
Author
|
My patch-2 branch was a mess so I have a new pull request for you at #1243. |
Member
|
Replaced by #1243 |
zannager
added
component: DatePicker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did not refactor the weird func(date, e) and func(e, date) in some functions since I'm not aware of how it's used throughout the library.