[code-infra] Fix fail-on-console breaking with --no-isolate --no-file-parallelism#1168
Merged
[code-infra] Fix fail-on-console breaking with --no-isolate --no-file-parallelism#1168
Conversation
Ensures lifecycle hooks aren't registered before failOnConsole sets up its own hooks, avoiding ordering issues. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Janpot
changed the title
Bundle size report
Check out the code infra dashboard for more information about this PR. |
Janpot
added
the
scope: code-infra
brijeshb42
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It sets up lifecycle hooks but they get cleared by
--no-isolate --no-file-parallelism. we need to make sure to set them up on each run.We just fixed 100+ broken tests in core that were hidden by this bug.