Skip to content

[support-infra] Fix duplicate GitHub Action running on PR comments#1230

Merged
oliviertassinari merged 1 commit intomasterfrom
fix-
Mar 20, 2026
Merged

[support-infra] Fix duplicate GitHub Action running on PR comments#1230
oliviertassinari merged 1 commit intomasterfrom
fix-

Conversation

@oliviertassinari
Copy link
Copy Markdown
Member

@oliviertassinari oliviertassinari commented Mar 20, 2026

We have this GitHub Action to do stuff like this: #642 (comment)

SCR-20260320-civo

However, I have noticed from a warning sent to admin@mui.com

SCR-20260320-cjmk

that this action also runs on PR comments. It seems absurd. For example, I have tried to trigger this logic in: https://github.com/mui/mui-private/pull/1526#issuecomment-4094571151 and the result was a failure of execution https://github.com/mui/mui-private/actions/runs/23323414405.

SCR-20260320-cjxi

so instead, let's only run the action on issue comments.


(For the Node.js warning, I have created actions-cool/issues-helper#228)

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. scope: support-infra Involves the support-infra product (https://www.notion.so/mui-org/1a4cbfe7b660809c8896d534a9c7d50f). labels Mar 20, 2026
@oliviertassinari oliviertassinari changed the title [support-infra] Fix Duplicate GitHub Action running on PR comments [support-infra] Fix duplicate GitHub Action running on PR comments Mar 20, 2026
@oliviertassinari oliviertassinari merged commit f9413d1 into master Mar 20, 2026
16 checks passed
@oliviertassinari oliviertassinari deleted the fix- branch March 20, 2026 15:22
oliviertassinari added a commit to mui/material-ui that referenced this pull request Mar 20, 2026
oliviertassinari added a commit to mui/toolpad that referenced this pull request Mar 20, 2026
oliviertassinari added a commit to mui/pigment-css that referenced this pull request Mar 20, 2026
oliviertassinari added a commit to mui/base-ui that referenced this pull request Mar 20, 2026
@oliviertassinari
Copy link
Copy Markdown
Member Author

oliviertassinari commented Mar 20, 2026

Ok, I have propagated this diff everywhere else.

I get the feeling that this will get more painful going forward, so I (Claude Code) has created two scripts for it: https://github.com/oliviertassinari/mui-olivier-tools/tree/master/scripts

Screen.Recording.2026-03-20.at.18.09.25.mov

Without this, propagating a change in 10 repositories is 💀😁


The next level would be to have a shared code block that signals the file is "locked" + a GitHub Action that fails the CI if a file that is locked is changed, so that changes can only be made from one repository. In this case, make it so mark-duplicate.yml is "locked". Of course, repositories could still remove the "lock" to try changes, before aligning everyone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: support-infra Involves the support-infra product (https://www.notion.so/mui-org/1a4cbfe7b660809c8896d534a9c7d50f). type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants