[support-infra] Fix duplicate GitHub Action running on PR comments#1230
Merged
oliviertassinari merged 1 commit intomasterfrom Mar 20, 2026
Merged
[support-infra] Fix duplicate GitHub Action running on PR comments#1230oliviertassinari merged 1 commit intomasterfrom
oliviertassinari merged 1 commit intomasterfrom
Conversation
Janpot
approved these changes
Mar 20, 2026
michelengelen
approved these changes
Mar 20, 2026
oliviertassinari
added a commit
to mui/material-ui
that referenced
this pull request
Mar 20, 2026
oliviertassinari
added a commit
to mui/toolpad
that referenced
this pull request
Mar 20, 2026
oliviertassinari
added a commit
to mui/pigment-css
that referenced
this pull request
Mar 20, 2026
oliviertassinari
added a commit
to mui/base-ui
that referenced
this pull request
Mar 20, 2026
oliviertassinari
added a commit
to mui/mui-x
that referenced
this pull request
Mar 20, 2026
Member
Author
|
Ok, I have propagated this diff everywhere else. I get the feeling that this will get more painful going forward, so I (Claude Code) has created two scripts for it: https://github.com/oliviertassinari/mui-olivier-tools/tree/master/scripts Screen.Recording.2026-03-20.at.18.09.25.movWithout this, propagating a change in 10 repositories is 💀😁 The next level would be to have a shared code block that signals the file is "locked" + a GitHub Action that fails the CI if a file that is locked is changed, so that changes can only be made from one repository. In this case, make it so mark-duplicate.yml is "locked". Of course, repositories could still remove the "lock" to try changes, before aligning everyone else. |
Janpot
pushed a commit
that referenced
this pull request
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have this GitHub Action to do stuff like this: #642 (comment)
However, I have noticed from a warning sent to admin@mui.com
that this action also runs on PR comments. It seems absurd. For example, I have tried to trigger this logic in: https://github.com/mui/mui-private/pull/1526#issuecomment-4094571151 and the result was a failure of execution https://github.com/mui/mui-private/actions/runs/23323414405.
so instead, let's only run the action on issue comments.
(For the Node.js warning, I have created actions-cool/issues-helper#228)