Skip to content

Conversation

@arminmeh
Copy link
Contributor

No description provided.

@arminmeh arminmeh added the release We are shipping :D. label Oct 10, 2024
@arminmeh arminmeh requested a review from a team October 10, 2024 10:04

### Charts

#### `@mui/[email protected]`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything to wait for here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I remove the charts completely from the changelog or add
No updates since @mui/[email protected].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We kept it for a previous empty of the Tree View, but it's super ugly
If you can apply the same logic as what we chose for the charts on today's release it would be great

I would be in favor of removing it entirely if we don't release it and keeping it with "No updates" if we don't release it.
Having it in the list if we don't release it is weird.
And if we release I think it's nice to have it but no strong opinion here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the changelog appearance and the release should be coupled

Semver does not require incrementing versions by 1, so we can skip releasing the package and not include it in the changelog. Next release, the version can be aligned with the other packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can apply the same logic as what we chose for the charts on today's release it would be great

@flaviendelangle you mean to update the script?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arminmeh Skipping releasing packages backfired a few times already, I strongly advise not to do so 😅
If the package was bumped by lerna – we should release it. I prefer having "No updates" for the packages that we release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can apply the same logic as what we chose for the charts on today's release it would be great

No manually updating the changelog for version 7.12.1

If the script can be improved I'm all in favor of doing it, but later on 😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should signal the lack of specific changes in such cases. 🤔
Can we add No changes. as we once did?
This would allow us to avoid the need to track the last release and put that in. 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added No changes since... entry
Also updated the script (with a bit more stuff 😅)

@mui-bot
Copy link

mui-bot commented Oct 10, 2024

Deploy preview: https://deploy-preview-14910--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f7b8772

arminmeh and others added 2 commits October 10, 2024 12:40
Co-authored-by: Flavien DELANGLE <[email protected]>
Signed-off-by: Armin Mehinovic <[email protected]>
arminmeh and others added 3 commits October 10, 2024 13:44
Co-authored-by: Flavien DELANGLE <[email protected]>
Signed-off-by: Armin Mehinovic <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]>
Signed-off-by: Armin Mehinovic <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]>
Signed-off-by: Armin Mehinovic <[email protected]>
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the @mui/x-charts discussion, this seems good to me

Congrats everyone, it's not a small release 🥳


### Charts

#### `@mui/[email protected]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should signal the lack of specific changes in such cases. 🤔
Can we add No changes. as we once did?
This would allow us to avoid the need to track the last release and put that in. 🙈


#### `@mui/[email protected]`

No changes since `@mui/[email protected]`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a hyperlink to the mentioned version make sense here?

Copy link
Contributor Author

@arminmeh arminmeh Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having a strong opinion on this one.
If you are scrolling through all releases, then it is the next one.
For the announcements, you probably already had the previous one so you don't need to remind yourself what was there.

Waiting for 👍 from the reviewers
>= 3 - I am adding it 😆

Copy link
Member

@MBilalShafi MBilalShafi Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a changelog, yes it doesn't make sense, but when on a particular release page, it might be helpful to have a link if another release is mentioned. Let's not block the release for this though, we can add it later too. 👍

I did one 👍 bdw. 😄

@arminmeh arminmeh merged commit d114e96 into mui:master Oct 11, 2024
5 checks passed
@arminmeh arminmeh deleted the release/7.20.0 branch October 11, 2024 10:51
@arminmeh arminmeh mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release We are shipping :D.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants