-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
v7.20.0 #14910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7.20.0 #14910
Conversation
|
|
||
| ### Charts | ||
|
|
||
| #### `@mui/[email protected]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything to wait for here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I remove the charts completely from the changelog or add
No updates since @mui/[email protected].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We kept it for a previous empty of the Tree View, but it's super ugly
If you can apply the same logic as what we chose for the charts on today's release it would be great
I would be in favor of removing it entirely if we don't release it and keeping it with "No updates" if we don't release it.
Having it in the list if we don't release it is weird.
And if we release I think it's nice to have it but no strong opinion here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the changelog appearance and the release should be coupled
Semver does not require incrementing versions by 1, so we can skip releasing the package and not include it in the changelog. Next release, the version can be aligned with the other packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can apply the same logic as what we chose for the charts on today's release it would be great
@flaviendelangle you mean to update the script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arminmeh Skipping releasing packages backfired a few times already, I strongly advise not to do so 😅
If the package was bumped by lerna – we should release it. I prefer having "No updates" for the packages that we release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can apply the same logic as what we chose for the charts on today's release it would be great
No manually updating the changelog for version 7.12.1
If the script can be improved I'm all in favor of doing it, but later on 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should signal the lack of specific changes in such cases. 🤔
Can we add No changes. as we once did?
This would allow us to avoid the need to track the last release and put that in. 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added No changes since... entry
Also updated the script (with a bit more stuff 😅)
|
Deploy preview: https://deploy-preview-14910--material-ui-x.netlify.app/ |
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
flaviendelangle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appart from the @mui/x-charts discussion, this seems good to me
Congrats everyone, it's not a small release 🥳
|
|
||
| ### Charts | ||
|
|
||
| #### `@mui/[email protected]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should signal the lack of specific changes in such cases. 🤔
Can we add No changes. as we once did?
This would allow us to avoid the need to track the last release and put that in. 🙈
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Armin Mehinovic <[email protected]>
|
|
||
| #### `@mui/[email protected]` | ||
|
|
||
| No changes since `@mui/[email protected]`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a hyperlink to the mentioned version make sense here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not having a strong opinion on this one.
If you are scrolling through all releases, then it is the next one.
For the announcements, you probably already had the previous one so you don't need to remind yourself what was there.
Waiting for 👍 from the reviewers
>= 3 - I am adding it 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a changelog, yes it doesn't make sense, but when on a particular release page, it might be helpful to have a link if another release is mentioned. Let's not block the release for this though, we can add it later too. 👍
I did one 👍 bdw. 😄

No description provided.