-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Line
if (DateTime.Now.Subtract(lastBackupTime).Ticks > backupTimeSpan.Ticks && CanBackup() && autoBackup)
Stack
Backup.CanBackup() ->
FastZip.isSupported ->
FastZip.path ->
AssetDatabase.FindAssets(string path) // Slowwww!!!!
Fix
Easy fix
Change the order of evaluation to && autoBackup && CanBackup()
, so the CanBackup
is only called when autobackup
is true.
Correct fix
Cache the results of FastZip.isSupported
and FastZip.path
.
ninpl
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working