initial pass converting to string-based multihashes#83
initial pass converting to string-based multihashes#83
Conversation
|
Ignore the broken CI. That's happening because we can't build GX with this version of go-multihash because it breaks go-multiaddr. |
|
Okay. When I initially did the conversion I tried to do a more complete conversion. If we are okay with leaving DecodedMultihash alone and leaving the functions that work on raw bytes alone I am okay with this. I would suggest we add a I created a second p.r. that continues this one: #84. |
My FromBinary() takes care of this in #84. I am okay with adding a few more checks but I want this to be fast as so that
I think we should keep this simple and just have a Parts() method as I did in #82 and carried over in #84. |
TODO:
Updates to reverse-dependencies:
Note: there are a bunch of
FIXME(steb)comments in these related to the thirdtodo. Currently, I'm just using
mh.Decode(hash.Bytes())but that kind of sucks.