chore: bump MSRV to 1.87 for copy slice in constfn #394
Conversation
|
code cov is failing on stderr, not sure why but thats all the time i have for today. |
|
The current MSRV of 1.64 is really old. I'm happy to use a newer version. Though moving to 1.87 seems like a bit too harsh version bump. If there's a really good reason to do it, that's also OK. but making the code a bit nicer is probably not good enough for me to justify that. |
|
The code style is whatever, its is just to make clippy happy. The only thing I am really attempting here is to turn copying with an iterator to a slice copy. There are likely some performance gains by doing so, I'll see if i can quickly do a bit of benching. Ultimately however it is a micro-optimization. |
|
Seems my desktop is too noisy to provide any meaningful benches. It honestly might not even be that noticeable since it probably squashes down to a memcpy after a few dozen iterations anyway. |
|
Looking at the assembly I don't think that little difference would practically make any performance difference: https://godbolt.org/z/enPTKKcs1. |
|
llvm ftw! |
fixes #203
https://blog.rust-lang.org/2025/05/15/Rust-1.87.0/