-
Notifications
You must be signed in to change notification settings - Fork 2.9k
French style beams option #21126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French style beams option #21126
Conversation
9630e18
to
c7284e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lovely addition.
From my POV, the only thing that probably needs rethinking is the UX/UI. My preference would be for a more visual toggle (2 buttons, à-la the "Beam distance" buttons, or even the "Ties" buttons), instead of the current checkbox.

This will require the briefest bit of design work. @avvvvve do you have capacity at the moment to tackle this?
I can take care of it if desired, except for the icons and their font. |
@XiaoMigros Thanks! I know @oktophonie already passed off the Figma link, but I'm posting a design screenshot here too for reference. |
dbcf301
to
ab4c1c9
Compare
ab4c1c9
to
5a54872
Compare
5a54872
to
9a16131
Compare
0cd6a7f
to
c943cc8
Compare
60d35a4
to
d03ebb1
Compare
fa1f8d3
to
525a11a
Compare
d03ebb1
to
95e11b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this.
Thanks @XiaoMigros. Good to go from my end!
src/framework/uicomponents/qml/MuseScore/UiComponents/StyledFrame.qml
Outdated
Show resolved
Hide resolved
background: Rectangle { | ||
y: root.topPadding - root.bottomPadding | ||
width: parent.width | ||
height: parent.height - root.topPadding + root.bottomPadding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed here to calculate the positon of the Rectangle relative to the text, bottomPadding
and topPadding
include label height.
src/framework/uicomponents/qml/MuseScore/UiComponents/StyledGroupBox.qml
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/BeamsPage.qml
Outdated
Show resolved
Hide resolved
src/framework/uicomponents/qml/MuseScore/UiComponents/StyledFrame.qml
Outdated
Show resolved
Hide resolved
ccb29fa
to
bf6e010
Compare
bf6e010
to
3e63b1c
Compare
background: Rectangle { | ||
y: root.topPadding - root.bottomPadding | ||
width: parent.width | ||
height: parent.height - root.topPadding + root.bottomPadding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I really don't get why it is calculated like this. Don't you mean
height: parent.height - root.topPadding + root.bottomPadding | |
height: parent.height - (root.topPadding + root.bottomPadding) |
?
In that case you can also use
height: parent.height - root.topPadding + root.bottomPadding | |
height: root.availableHeight |
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I see now that you got it from https://doc.qt.io/qt-5/qtquickcontrols2-customize.html#customizing-groupbox. So either that tutorial is weird or I just don't get it. Anyway, if it works, it works.
Is this going into 4.3.0 too? |
No, it's currently scheduled for 4.4 |
This PR adds a style option to draw stems up to the first beam rather than the top beam, where suited