[a11y and i18n] Translate time phrases#1232
Merged
Merged
Conversation
|
@manuhabitela is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
Before that, the duration labels meant for assistive tech like screen readers were not translated, rendering for example "1 hour remaining" when using the French locale. Now all necessary strings are passed through the i18n translation function. ⚠: only the English and French strings are legit. I can't vouch for other locales where AI did its thing.
manuhabitela
force-pushed
the
translate-playback-label
branch
from
1e70928 to
2760794
Compare
Contributor
Author
|
Hey there, Do I have to do something specific that I missed to get an answer here? 😅 Thanks |
Contributor
|
@manuhabitela Thank you very much for taking the time to look into the code and collaborate on this missing part of media-chrome's internationalization. We greatly appreciate it. |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey there,
Thanks for media-chrome.
This is a tiny suggestion to improve the experience of non-English speaking users of assistive technologies like screen readers.
The duration labels meant for assistive tech were not translated, rendering for example "1 hour remaining" when using the French locale. Now all necessary strings are passed through the i18n translation function.
I thought of using Intl.DurationFormat but since browser support is very recent I figured it was not that great of an idea for now.
Sorry if this is not complete enough (like maybe missing tests or anything else), I'm just discovering the code.
Cheers!