fix: DRM playback broken + logging problems #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daytime-em
force-pushed
the
fix/drm-playback
branch
from
f5aba97 to
edfbc74
Compare
daytime-em
changed the title
CFKevinRef
approved these changes
Jul 11, 2025
Merged
daytime-em
added a commit
that referenced
this pull request
Jul 14, 2025
## Improvements * Update media3 version to 1.6.1 (#78) * Update Mux Data to v1.8.0 ## Fixes * fix: DRM playback broken (#79) Co-authored-by: Emily Dixon <[email protected]> Co-authored-by: GitHub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our implementation of
executeProvisionRequestwas not correctFor Widevine flows, it wasn't called by media3 when we first implemented the DRM feature. A media3 update change this, which exposed the incorrect implementation and broke our DRM playback
We should be calling out to the widevine API for provisioning, and only using our license proxy for key requests