CMake integration improvements + README update#22
CMake integration improvements + README update#22WeGoToMars wants to merge 5 commits intomxmlnkn:masterfrom
Conversation
Funny coincidence, and thanks for the feedback. Only GNU assembler being supported might be true. Was that
|
mxmlnkn
changed the title
|
@mxmlnkn |
|
I tried to get it to work with ISA-L on macOS (macos-13 (x86-64), macos-14/15) in Github Actions but failed to do so. I am running into a myriad of different errors, including weird SIGBUS errors after finally getting it to build!? I think I'll have to disable ISA-L support for macOS, even though it seemed to have worked somewhat for you (did it? did all the tests run?) and your ISA-L issue even got fixed. It is also no fun that have I to keep two parallel build systems (CMake and setup.py) up to date. And I have not yet found out how to compile multiarch fat binaries with setup.py for macOS, which it seems to try by default (
I tried using the new ISA-L CMake system but it also seems to be unfinished: intel/isa-l#61 (comment) If you have time, could you try to run |
| #include <rapidgzip/ParallelGzipReader.hpp> | ||
|
|
||
| int main() { | ||
| // Create a file reader for the gzipped file |
|
Merged manually. |
2 participants
Following up on mxmlnkn/rapidgzip#59
By the way, I see that you are currently working on adding support for compiling ISA-L for ARM, but the build couldn't be finished on my ARM Mac. Using the clang compiler, I get an error when assembling one of the files:
I was able to get it fixed by changing
movk x7, p4_low_b1, lsl 16tomovk x7, p4_low_b1, lsl #16, but I assume ISA-L has general issues with ARM Macs and only GNU assembler is supported?After disabling building ISA-L with an option, the rest of the project compiles without a problem on macOS (apart from one of the benchmarks that requires Linux/POSIX functions).