CT-GT ガイドの完全移行とスタイル調整#76
Merged
Merged
Conversation
✅ Deploy Preview for quality-assurance-studies ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📝 WalkthroughSummary by CodeRabbitリリースノート
WalkthroughCT-GT ガイドの新規追加と 33 個の既存ガイド UI 刷新。NavBar・スタイル・ナビゲーション登録・テスト・ドキュメント更新でサイト移行完成、並びに BDD/AI/受理テスト等のグリッド・CSS・DOM・アクセシビリティ向上とテスト import 整理。 ChangesCT-GT ガイド移行完成
既存ガイド UI・表示構造・アクセシビリティ改善
テスト基盤整理
🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css`:
- Around line 61-113: Add a prefers-reduced-motion media query that disables
animations for fadeInDown, fadeInUp, growBar, pulse, and glow by setting
animation: none for the elements that use them and ensure elements using the
growBar (e.g., .progress-bar) still show their intended width by applying width:
var(--bar-width, 70%) (or a concrete fallback) when animations are turned off;
place this block at the end of the CSS file and target the specific
selectors/classes that use those animations so reduced-motion users still see
correct content (refer to animation names fadeInDown, fadeInUp, growBar, pulse,
glow and the .progress-bar selector).
In `@app/istqb-ct-gt-complete-guide/NavBar.tsx`:
- Around line 31-37: Add the aria-current="location" attribute to the active
anchor elements so accessibility reflects the active state; where you currently
compute className using activeId (e.g., the <a href="`#hero`">, <a href="`#ch0`">,
<a href="`#ch1`">, <a href="`#ch2`">, <a href="`#ch3`">, <a href="`#exam`">, <a
href="`#references`"> anchors), add aria-current={activeId === 'hero' ? 'location'
: undefined} (or equivalent conditional) for each anchor so the attribute is
present only when that link is active.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3f55515d-5ef9-4615-8b92-79ca503ea51a
📒 Files selected for processing (16)
CLAUDE.mdGEMINI.mdapp/istqb-ct-gt-complete-guide/NavBar.tsxapp/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.cssapp/istqb-ct-gt-complete-guide/page.tsxdocs/MIGRATION_PROGRESS.mddocs/coverage-dashboard.htmle2e/pages.tsistqb-ct-game-complete-guide.htmlistqb-ct-game-complete-guide.mdistqb-ct-gt-complete-guide.htmlistqb-ct-gt-complete-guide.mdlib/navigation.tsnext-env.d.tstests/istqb-ct-gt-complete-guide/page.test.tsxtests/lib/navigation.test.ts
💤 Files with no reviewable changes (2)
- istqb-ct-game-complete-guide.md
- istqb-ct-gt-complete-guide.md
…ull-width issue in CT-GT guide
Owner
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Owner
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css`:
- Around line 1073-1089: The prefers-reduced-motion block targets non-existent
selectors; update it to target the actual animated classes (.hero,
.hero-eyebrow, .hero h1, .hero-sub, .hero-meta, .toc-card) and set animation:
none !important for each, and for .progress-bar set animation: none !important
plus max-width: 100% !important (keep width: var(--bar-width, 70%) as fallback
if needed). Locate the existing `@media` (prefers-reduced-motion: reduce) rule and
replace the listed selectors (.hero-title, .hero-subtitle, .hero-desc,
.hero-btn, .neon-text, .neon-box) with the concrete symbols above so the
reduced-motion preference actually disables those animations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 964a8215-3872-48f3-97be-db228cc9e17f
📒 Files selected for processing (3)
app/istqb-ct-gt-complete-guide/NavBar.tsxapp/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.cssapp/istqb-ct-gt-complete-guide/page.tsx
…get selectors and progress-bar styles
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css (2)
32-45: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick winオーバーレイを前面レイヤーに置かないでください。
この
::before/::afterはposition: fixedかつz-index: 9999/9998なので、クリックは透過しても常に全コンテンツの前面に描画されます。ガイドラインどおりz-index: 0か-1に落とし、必要ならページ側でスタッキングコンテキストを作って背面に固定してください。As per coding guidelinesFor overlays using ::before or ::after pseudo-elements ... include pointer-events: none and z-index: 0 or -1 to prevent blocking clicks.Also applies to: 48-57
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css` around lines 32 - 45, The overlay pseudo-element (.istqb-ct-gt-page::before and the corresponding ::after) uses position: fixed with z-index: 9999 which forces it above all content; change the z-index to 0 or -1 so it sits behind page content and keep pointer-events: none; if you need it visually behind positioned content, ensure the page container creates a stacking context (e.g., by adding position: relative/transform) so the pseudo-elements remain fixed but do not block clicks.Source: Coding guidelines
2-20:⚠️ Potential issue | 🟠 MajorCT-GT CSS のローカルCSS変数名が参照名と不一致で、意図した色/フォント上書きが効いていない
app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css（2-20行目）では--bg-card/--neon-green/--font-head等を定義している一方で、同ファイルとapp/istqb-ct-gt-complete-guide/page.tsxはvar(--color-bg-card)/var(--color-accent-green)/var(--font-display)を参照しているため、このファイル側のローカル定義は参照されず上書きになっていない。- ただし
app/globals.css（app/layout.tsxで読み込み済み）に--color-*/--font-displayは定義されているため「未定義で全部無効」にはならないが、CT-GT用のパレットが反映されず見た目が意図とズレる可能性が高い。- 対応: ローカル変数名を
--color-*/--font-displayに合わせるか、参照側（var(--color-*)/var(--font-display)）をローカル定義名に合わせて統一すること。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css` around lines 2 - 20, Local CSS custom properties in the CT-GT stylesheet are mismatched with the properties referenced elsewhere (e.g., page.tsx), so the intended palette/font overrides aren't applied; fix by renaming the local variables to match the referenced names or by updating the references to match the local names. Specifically, in the CT-GT CSS change variables like --bg-card, --neon-green, --font-head (and any other --bg-*, --neon-*, --text-*, --font-*) to the global naming convention used by the page (for example --color-bg-card, --color-accent-green, --font-display), or alternatively update the var(...) references in page.tsx from var(--color-*)/var(--font-display) to use the existing --bg-*/--neon-* and --font-head names so both sides use the same identifiers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css`:
- Around line 32-45: The overlay pseudo-element (.istqb-ct-gt-page::before and
the corresponding ::after) uses position: fixed with z-index: 9999 which forces
it above all content; change the z-index to 0 or -1 so it sits behind page
content and keep pointer-events: none; if you need it visually behind positioned
content, ensure the page container creates a stacking context (e.g., by adding
position: relative/transform) so the pseudo-elements remain fixed but do not
block clicks.
- Around line 2-20: Local CSS custom properties in the CT-GT stylesheet are
mismatched with the properties referenced elsewhere (e.g., page.tsx), so the
intended palette/font overrides aren't applied; fix by renaming the local
variables to match the referenced names or by updating the references to match
the local names. Specifically, in the CT-GT CSS change variables like --bg-card,
--neon-green, --font-head (and any other --bg-*, --neon-*, --text-*, --font-*)
to the global naming convention used by the page (for example --color-bg-card,
--color-accent-green, --font-display), or alternatively update the var(...)
references in page.tsx from var(--color-*)/var(--font-display) to use the
existing --bg-*/--neon-* and --font-head names so both sides use the same
identifiers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 179d8ff1-f220-48af-a411-2d1763d2f0e3
📒 Files selected for processing (1)
app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css
… naming convention
Owner
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/ai-test-guide/page.tsx (1)
419-462:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift混同行列の意味関係が支援技術に伝わりません。
見た目は整っていますが、これは
divベースのグリッドなので、スクリーンリーダーには「どの列・行に対する TP/FN/FP/TN なのか」が伝わりません。教育コンテンツの核になる図なので、table/thead/tbody/th scope/tdに置き換えるか、少なくとも表相当の ARIA ロールとヘッダ関連付けを追加してください。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/ai-test-guide/page.tsx` around lines 419 - 462, The current grid uses divs (matrix-wrap, matrix-grid, matrix-cell, and specific cells tp, fn, fp, tn) which is inaccessible to screen readers; replace this structure with a semantic table using <table>, <thead>, <tbody>, and <th scope="col">/<th scope="row"> and <td> for the TP/FN/FP/TN cells so assistive tech can associate headers with cells, or if you must keep divs apply ARIA table semantics (role="table" on matrix-grid, role="row" on row wrappers, role="columnheader"/role="rowheader" on header cells and role="cell" on tp/fn/fp/tn) and link headers and cells with appropriate aria-colindex/aria-rowindex or aria-labelledby attributes; ensure the vertical headers (currently vertical-header) use rowheader semantics and the top headers use columnheader semantics so screen readers correctly convey which header applies to each TP/FN/FP/TN cell.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/ai-guide.css`:
- Around line 161-172: 親要素の .matrix-wrap に横スクロールがないため幅固定の .matrix-grid
(grid-template-columns: 50px 170px 170px) が狭い画面で切れてしまっています；修正は .matrix-wrap に
overflow-x: auto を追加して横スクロールで逃がすか、あるいは狭幅用にメディアクエリを追加して .matrix-grid の
grid-template-columns を縮める（例: 50px 130px 130px など）ようにしてください；対象の識別子は .matrix-wrap
と .matrix-grid、プロパティは grid-template-columns と overflow-x です。
In `@app/bdd-testing-guide.css`:
- Around line 188-190: .bdd-guide-page .bdd-toc-card:hover の border-color は未定義の
CSS 変数 --cyber-border-bright
を参照して無効になっているため、ホバー時の境界色が反映されません。該当セレクタ（.bdd-guide-page .bdd-toc-card:hover）内で
--cyber-border-bright を使う代わりに既存のトークン --cyber-border-hover
を参照するように置き換えるか、グローバルなカスタムプロパティ定義に --cyber-border-bright
を追加して正しい色値を提供してください。類似の箇所（同様の TOC/カードの hover スタイル、コメントで指摘されたもう一箇所）も同様に修正してください。
In `@app/e2e-testing-guide/page.tsx`:
- Around line 917-927: The .code-block currently relies on
dangerouslySetInnerHTML with embedded "\n" (see the two <pre
dangerouslySetInnerHTML=...> usages rendering the LoginPage and tests examples);
change those renderings to output each source line as a separate <div
className="code-line"> element (map the string by splitting on "\n" and render
each chunk as a code-line) instead of injecting raw HTML, and ensure the wrapper
.code-block markup uses those code-line children so line-wrapping/styles remain
stable; keep the original HTML content but produce it via JSX elements rather
than dangerouslySetInnerHTML.
In `@app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css`:
- Around line 31-40: Remove the self-referential CSS custom properties inside
the .istqb-ct-gt-page rule (the --color-accent-*, --color-text-*, --font-*,
--color-bg-card entries that are set to var(--same-name)); these create circular
references and invalidate the variables. Edit the .istqb-ct-gt-page block to
delete those var(--...) assignments so the component inherits the authoritative
values from app/globals.css :root (or replace with explicit fallbacks/new
variable names if you need local overrides), ensuring no declaration like
--color-accent-green: var(--color-accent-green) remains.
In `@happydom-setup.ts`:
- Around line 26-27: IntersectionObserverMock の observe()/unobserve()
が引数なしで定義されており、実際の使用側は observer.observe(section) のように Element を渡しているため API
署名を標準に合わせてください。具体的には IntersectionObserverMock.observe(target: Element): void と
IntersectionObserverMock.unobserve(target: Element): void のシグネチャに変更し（必要なら target
を Element | null にして安全化）、既存の内部実装は受け取った target
を無視するか登録/削除ロジックに渡すように修正して型エラーを解消してください。
---
Outside diff comments:
In `@app/ai-test-guide/page.tsx`:
- Around line 419-462: The current grid uses divs (matrix-wrap, matrix-grid,
matrix-cell, and specific cells tp, fn, fp, tn) which is inaccessible to screen
readers; replace this structure with a semantic table using <table>, <thead>,
<tbody>, and <th scope="col">/<th scope="row"> and <td> for the TP/FN/FP/TN
cells so assistive tech can associate headers with cells, or if you must keep
divs apply ARIA table semantics (role="table" on matrix-grid, role="row" on row
wrappers, role="columnheader"/role="rowheader" on header cells and role="cell"
on tp/fn/fp/tn) and link headers and cells with appropriate
aria-colindex/aria-rowindex or aria-labelledby attributes; ensure the vertical
headers (currently vertical-header) use rowheader semantics and the top headers
use columnheader semantics so screen readers correctly convey which header
applies to each TP/FN/FP/TN cell.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1f0315d1-8fcf-48d9-8ce0-cc5c606fc475
📒 Files selected for processing (28)
CLAUDE.mdGEMINI.mdapp/acceptance-testing-guide.cssapp/acceptance-testing-guide/page.tsxapp/ai-guide.cssapp/ai-test-guide/page.tsxapp/bdd-testing-guide.cssapp/bdd-testing-guide/page.tsxapp/e2e-testing-guide/page.tsxapp/integration-system-testing-guide.cssapp/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.cssapp/istqb-ct-gt-complete-guide/page.tsxapp/unit-testing.cssdocs/MIGRATION_PROGRESS.mdhappydom-setup.tstests/istqb-ct-ai-complete-guide/page.test.tsxtests/istqb-ct-aut-complete-guide/page.test.tsxtests/istqb-ct-genai-complete-guide/page.test.tsxtests/istqb-ct-pt-complete-guide/page.test.tsxtests/istqb-ct-sec-complete-guide/page.test.tsxtests/istqb-ct-ste-complete-guide/page.test.tsxtests/istqb-ct-ut-complete-guide/page.test.tsxtests/istqb-ctal-att-complete-guide/page.test.tsxtests/istqb-ctel-itp-atp-complete-guide/page.test.tsxtests/istqb-ctel-itp-itpi-complete-guide/page.test.tsxtests/istqb-ctel-tm-mtt-complete-guide/page.test.tsxtests/istqb-ctel-tm-otm-complete-guide/page.test.tsxtests/istqb-ctel-tm-sm-complete-guide/page.test.tsx
… table semantics, and IntersectionObserverMock signature
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/bdd-testing-guide/page.tsx (1)
1591-1596:⚠️ Potential issue | 🟡 Minor | ⚡ Quick win外部リンクにセキュリティ属性が不足しています。
セクション14の参照URL一覧にある全ての外部リンク（約40件）に
target="_blank" rel="noopener noreferrer"が設定されていません。コーディングガイドラインに従い、外部リンクには新規タブで開く設定とセキュリティ属性を追加してください。🔧 修正例（1つのリンクの例）
-<a href="https://istqb.org/" className="ref-url">https://istqb.org/</a> +<a href="https://istqb.org/" className="ref-url" target="_blank" rel="noopener noreferrer">https://istqb.org/</a>Based on learnings: コーディングガイドラインにて「Add
target="_blank" rel="noopener noreferrer"to all external links in JSX/TSX files for security and user experience」と規定されています。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/bdd-testing-guide/page.tsx` around lines 1591 - 1596, The external links in the references table are missing security attributes; locate the anchor elements with className "ref-url" in the Section 14 references (in app/bdd-testing-guide/page.tsx, the <a className="ref-url"> elements) and add target="_blank" rel="noopener noreferrer" to each external link element so every external URL opens in a new tab and includes the noopener/noreferrer security attributes; apply this consistently to all ~40 external anchors in that section.Source: Coding guidelines
♻️ Duplicate comments (1)
app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css (1)
21-23:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
--font-mono/--font-bodyが自己参照になっており、CSS変数が無効化されますLine 21 と Line 23 は循環参照です。
font-family: var(--font-mono)等の解決時に無効値化し、意図したフォント適用が崩れる可能性があります。ローカル再定義を削除してグローバル定義を継承させてください。修正案（最小差分）
- --font-mono: var(--font-mono); --font-head: var(--font-display); - --font-body: var(--font-body);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css` around lines 21 - 23, The CSS has self-referential variable declarations (--font-mono and --font-body) which cause invalidation; remove the local redefinitions of --font-mono and --font-body in the stylesheet so they inherit the global definitions instead (leave other variables like --font-head if they reference valid globals). After removing those declarations, verify places using font-family: var(--font-mono) and font-family: var(--font-body) resolve to the intended global values.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/ai-test-guide/page.tsx`:
- Around line 422-423: The inline style style={{ display: 'contents' }} used on
the row div (the element with role="row" and className "matrix-cell header") is
duplicated in three places; replace these inline styles with a CSS/Tailwind
class (e.g., add className "contents" or a custom CSS class) and remove the
style prop from the divs to comply with the app/**/*.{ts,tsx} guideline to avoid
inline styles; update the three occurrences (the role="row" divs) to use the
shared class instead.
In `@app/e2e-testing-guide/page.tsx`:
- Around line 917-949: The snippet renders a <pre> whose children are
div.code-line (invalid phrasing-content nesting) which can trigger SSR/React DOM
correction; locate the JSX that wraps the LoginPage code sample (the <pre>
element containing multiple div.className="code-line" entries) and fix by either
replacing the outer <pre> with a semantically appropriate block element (e.g.,
<div> or <figure> with the same styling) or by converting each child
div.code-line into phrasing elements (e.g., <span className="code-line">) so the
contents remain valid inside <pre>; update only the rendering markup around the
code sample (the block that contains the LoginPage class, goto/login/loginButton
lines) and preserve visual styling via CSS.
---
Outside diff comments:
In `@app/bdd-testing-guide/page.tsx`:
- Around line 1591-1596: The external links in the references table are missing
security attributes; locate the anchor elements with className "ref-url" in the
Section 14 references (in app/bdd-testing-guide/page.tsx, the <a
className="ref-url"> elements) and add target="_blank" rel="noopener noreferrer"
to each external link element so every external URL opens in a new tab and
includes the noopener/noreferrer security attributes; apply this consistently to
all ~40 external anchors in that section.
---
Duplicate comments:
In `@app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css`:
- Around line 21-23: The CSS has self-referential variable declarations
(--font-mono and --font-body) which cause invalidation; remove the local
redefinitions of --font-mono and --font-body in the stylesheet so they inherit
the global definitions instead (leave other variables like --font-head if they
reference valid globals). After removing those declarations, verify places using
font-family: var(--font-mono) and font-family: var(--font-body) resolve to the
intended global values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1499fbab-27fd-4b4e-a8b5-dadf96d0c9c7
📒 Files selected for processing (28)
CLAUDE.mdGEMINI.mdapp/acceptance-testing-guide.cssapp/acceptance-testing-guide/page.tsxapp/ai-guide.cssapp/ai-test-guide/page.tsxapp/bdd-testing-guide.cssapp/bdd-testing-guide/page.tsxapp/e2e-testing-guide/page.tsxapp/integration-system-testing-guide.cssapp/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.cssapp/istqb-ct-gt-complete-guide/page.tsxapp/unit-testing.cssdocs/MIGRATION_PROGRESS.mdhappydom-setup.tstests/istqb-ct-ai-complete-guide/page.test.tsxtests/istqb-ct-aut-complete-guide/page.test.tsxtests/istqb-ct-genai-complete-guide/page.test.tsxtests/istqb-ct-pt-complete-guide/page.test.tsxtests/istqb-ct-sec-complete-guide/page.test.tsxtests/istqb-ct-ste-complete-guide/page.test.tsxtests/istqb-ct-ut-complete-guide/page.test.tsxtests/istqb-ctal-att-complete-guide/page.test.tsxtests/istqb-ctel-itp-atp-complete-guide/page.test.tsxtests/istqb-ctel-itp-itpi-complete-guide/page.test.tsxtests/istqb-ctel-tm-mtt-complete-guide/page.test.tsxtests/istqb-ctel-tm-otm-complete-guide/page.test.tsxtests/istqb-ctel-tm-sm-complete-guide/page.test.tsx
…s, and CSS variables
Owner
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/e2e-testing-guide.css`:
- Around line 643-653: The CSS for .page-e2e .code-pre-div should not enforce
line breaks via white-space: pre; switch to the repository convention by
removing or neutralizing white-space on .code-pre-div and instead add/adjust
rules for .page-e2e .code-line (e.g., ensure .code-line uses white-space: pre
and display: block, inherit font-family/font-size/line-height/color from the
container, and handle padding/overflow on the container if needed) so code
blocks are represented per-line with .code-line elements and wrapping behavior
is consistent with the project's guideline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3c8e9530-a86f-4932-b2b0-3c8c582703fc
📒 Files selected for processing (6)
app/ai-test-guide/page.tsxapp/bdd-testing-guide/page.tsxapp/e2e-testing-guide.cssapp/e2e-testing-guide/page.tsxapp/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.cssnext-env.d.ts
💤 Files with no reviewable changes (1)
- app/istqb-ct-gt-complete-guide/istqb-ct-gt-complete-guide.css
Owner
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Owner
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Contributor
|
Note Docstrings generation - SUCCESS |
Docstrings generation was requested by @myoshi2891. * #76 (comment) The following files were modified: * `app/acceptance-testing-guide/page.tsx` * `app/ai-test-guide/page.tsx` * `app/e2e-testing-guide/page.tsx` * `app/istqb-ct-gt-complete-guide/NavBar.tsx`
Merged
📝 Add docstrings to `dev`
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
app/e2e-testing-guide/page.tsx (1)
967-998:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
<pre>配下にdiv.code-lineが残っており、DOM補正リスクがありますLine 967 の
<pre>が Line 968-998 のdiv.code-lineを直接子要素に持っており、HTML内容モデルに反します。SSR時のDOM補正/ハイドレーション不一致リスクがあるため、上段と同様にcode-pre-divへ統一してください。修正案（最小差分）
- <pre> + <div className="code-pre-div"> <div className="code-line"><span className="cm">// tests/auth.spec.ts</span></div> <div className="code-line"><span className="kw">import</span> &`#123`; test, expect &`#125`; <span className="kw">from</span> <span className="str">'`@playwright/test`'</span>;</div> <div className="code-line"><span className="kw">import</span> &`#123`; <span className="cls">LoginPage</span> &`#125`; <span className="kw">from</span> <span className="str">'../pages/LoginPage'</span>;</div> ... - </pre> + </div>As per coding guidelines,
app/**/*.tsxでは.code-block内のコード行を<div className="code-line">構造で安定表示する運用が必須です。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/e2e-testing-guide/page.tsx` around lines 967 - 998, The snippet uses a raw <pre> element containing multiple <div className="code-line"> children which violates HTML content models and risks SSR hydration fixes; replace the <pre> wrapper with a <div className="code-pre-div"> (or <div className="code-pre-div code-block"> per project convention) around the existing <div className="code-line"> lines so the inner structure remains identical but the wrapper is a valid container; ensure you update both the opening <pre> and its closing tag to the new <div> and leave all LoginPage/test code lines untouched.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@app/e2e-testing-guide/page.tsx`:
- Around line 967-998: The snippet uses a raw <pre> element containing multiple
<div className="code-line"> children which violates HTML content models and
risks SSR hydration fixes; replace the <pre> wrapper with a <div
className="code-pre-div"> (or <div className="code-pre-div code-block"> per
project convention) around the existing <div className="code-line"> lines so the
inner structure remains identical but the wrapper is a valid container; ensure
you update both the opening <pre> and its closing tag to the new <div> and leave
all LoginPage/test code lines untouched.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9c41a0cc-1a84-402d-be61-7fc6afa7c3ec
📒 Files selected for processing (4)
app/acceptance-testing-guide/page.tsxapp/ai-test-guide/page.tsxapp/e2e-testing-guide/page.tsxapp/istqb-ct-gt-complete-guide/NavBar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
主な変更内容は以下の通りです。