chore: migrate to rust edition 2024, align formatting with iroh standards#90
Open
chore: migrate to rust edition 2024, align formatting with iroh standards#90
Conversation
matheus23
reviewed
Feb 12, 2026
src/lib.rs
Outdated
Comment on lines
1015
to
1019
| match (self.f)(value) { Some(v) => { | ||
| self.sender.send(v).await | ||
| } else { | ||
| } _ => { | ||
| Ok(()) | ||
| } | ||
| }} |
Member
Author
There was a problem hiding this comment.
Uh yeah, reran fmt, dunno what was going on there
matheus23
reviewed
Feb 12, 2026
src/lib.rs
Outdated
Comment on lines
1028
to
1032
| match (self.f)(value) { Some(v) => { | ||
| self.sender.try_send(v).await | ||
| } else { | ||
| } _ => { | ||
| Ok(true) | ||
| } | ||
| }} |
matheus23
approved these changes
Feb 12, 2026
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
Ty for doing this.
It might be worth looking at the added + use<..> bounds and making sure that they're the right ones, and that they make sense in conjunction with + 'static.
Member
Author
|
I pushed a commit that adds the I checked the |
Frando
changed the title
matheus23
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates to edition 2024