Open
Conversation
…ants The normal variants can now be used both with and without 0rtt. Also update example.
This is a breaking change.
36692d3 to
e44112a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, they are not yet removed but just marked as deprecated.
You can now just call the normal ones, and they will work for 0rtt connections as well. This has no measurable overhead. See benchmarks below.
We also rename the somewhat internal fn zero_rtt_accepted in RemoteConnection to zero_rtt_rejected. This is so the code reads nicer for the case where there isn't any 0rtt to begin with.
This is a pretty obscure part of the API, but nevertheless is a breaking change.
This branch:
main: