Open
Conversation
Also add example using governor
Also introduce error code for rate limiting.
Member
|
Is the irpc-iroh rate limiter compatible with using a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements hooks to implement rate limiting for irpc and iroh. You can rate limit / filter based on SocketAddr (for irpc) and SocketAddr and EndpointId (for irpc-iroh).
You can filter by SocketAddr even before the SocketAddr is validated, but you should usually wait until it is validated, otherwise somebody could send you spoofed packets and rate limit valid clients.
There is also a system in place to allow for per-request rate limiting and filtering. This is the same for irpc and irpc-iroh.