-
Notifications
You must be signed in to change notification settings - Fork 52.8k
feat: Add N8N_GIT_NODE_DISABLE_BARE_REPOS environment variable to allow users to disable bare repositories in Git Node #19559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add N8N_GIT_NODE_DISABLE_BARE_REPOS environment variable to allow users to disable bare repositories in Git Node #19559
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 6 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/nodes-base/nodes/Git/__test__/Git.node.test.ts">
<violation number="1" location="packages/nodes-base/nodes/Git/__test__/Git.node.test.ts:112">
Assert absence of 'safe.bareRepository=explicit' instead of exact empty array to avoid brittle tests.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
michael-radency
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
E2E Tests: n8n tests passed after 6m 17s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
|
Got released with |
…ow users to disable bare repositories in Git Node (n8n-io#19559)
…ow users to disable bare repositories in Git Node (#19559)
Summary
Add
N8N_GIT_NODE_DISABLE_BARE_REPOSenvironment variable which disables support for bare repositories in Git Node when set totrue. Also disable bare repositories altogether for cloud deployment type. Add warning on startup if the user hasn't specified any value for the environment variableRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-3614/remote-code-execution-via-git-node
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)