Lints-year-sweep: #566 invalid-name-notation, #155 too-deep-object, #65 README embed GHA

.github/workflows/lints-readme.yml

@@ -0,0 +1,34 @@
+# SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
+# SPDX-License-Identifier: MIT
+---
+name: Update Lints README
+on:
+  push:
+    branches: [master]
+  workflow_dispatch:
+
+permissions:
+  contents: write
+
+jobs:
+  update-readme:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-java@v4
+        with:
+          distribution: temurin
+          java-version: '21'
+          cache: maven
+      - name: Update Lints README
+        run: |
+          mvn -q -ntp -P!hone,qulice exec:java \
+            -Dexec.mainClass=org.eolang.lints.LintsReadmeGenerator \
+            -Dexec.args="./README.md"
+      - name: Commit README
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          git add README.md
+          git diff --cached --quiet || git commit -m "chore: update lints README [skip ci]"
+          git push

.github/workflows/markdown-lint.yml

@@ -16,4 +16,4 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v6
-      - uses: DavidAnson/markdownlint-cli2-action@v23.0.0
+      - uses: DavidAnson/markdownlint-cli2-action@v23.2.0

.github/workflows/typos.yml

@@ -16,6 +16,6 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v6
-      - uses: crate-ci/typos@v1.45.1
+      - uses: crate-ci/typos@v1.47.0
         with:
           config: ./.github/typos.toml

.github/workflows/vale.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
-      - uses: errata-ai/vale-action@v2.1.1
+      - uses: errata-ai/vale-action@2.1.2
         with:
           files: 'src/main/resources/org/eolang/motives'
           fail_on_error: 'true'

pom.xml

@@ -76,7 +76,7 @@
     <dependency>
       <groupId>com.jcabi</groupId>
       <artifactId>jcabi-xml</artifactId>
-      <version>0.35.0</version>
+      <version>0.37.0</version>
     </dependency>
     <dependency>
       <groupId>io.github.secretx33</groupId>
@@ -86,12 +86,12 @@
     <dependency>
       <groupId>org.cactoos</groupId>
       <artifactId>cactoos</artifactId>
-      <version>0.59.0</version>
+      <version>0.61.0</version>
     </dependency>
     <dependency>
       <groupId>net.sf.saxon</groupId>
       <artifactId>Saxon-HE</artifactId>
-      <version>12.9</version>
+      <version>13.0</version>
       <scope>runtime</scope>
     </dependency>
     <dependency>
@@ -117,17 +117,17 @@
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
-      <version>2.0.17</version>
+      <version>2.0.18</version>
     </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-reload4j</artifactId>
-      <version>2.0.17</version>
+      <version>2.0.18</version>
     </dependency>
     <dependency>
       <groupId>org.eolang</groupId>
       <artifactId>eo-parser</artifactId>
-      <version>0.60.0</version>
+      <version>0.61.0</version>
       <scope>compile</scope>
       <exclusions>
         <exclusion>
@@ -179,13 +179,13 @@
     <dependency>
       <groupId>com.yegor256</groupId>
       <artifactId>mktmp</artifactId>
-      <version>0.0.5</version>
+      <version>0.1.0</version>
       <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>com.yegor256</groupId>
       <artifactId>together</artifactId>
-      <version>0.1.2</version>
+      <version>0.2.0</version>
       <scope>test</scope>
     </dependency>
     <dependency>
@@ -197,7 +197,7 @@
     <dependency>
       <groupId>com.yegor256</groupId>
       <artifactId>maybeslow</artifactId>
-      <version>0.0.4</version>
+      <version>0.1.0</version>
       <scope>test</scope>
     </dependency>
     <dependency>
@@ -227,7 +227,7 @@
     <dependency>
       <groupId>com.jcabi</groupId>
       <artifactId>jcabi-matchers</artifactId>
-      <version>1.8.0</version>
+      <version>1.9.0</version>
       <scope>test</scope>
     </dependency>
     <dependency>
@@ -251,7 +251,7 @@
     <dependency>
       <groupId>org.ow2.asm</groupId>
       <artifactId>asm</artifactId>
-      <version>9.9.1</version>
+      <version>9.10.1</version>
       <scope>test</scope>
     </dependency>
     <dependency>
@@ -324,7 +324,7 @@
           <plugin>
             <groupId>com.qulice</groupId>
             <artifactId>qulice-maven-plugin</artifactId>
-            <version>0.27.5</version>
+            <version>0.27.6</version>
             <configuration>
               <excludes combine.children="append">
                 <exclude>pmd:/src/it/.*</exclude>
@@ -385,7 +385,7 @@
           <plugin>
             <groupId>org.eolang</groupId>
             <artifactId>hone-maven-plugin</artifactId>
-            <version>0.25.0</version>
+            <version>0.26.2</version>
             <executions>
               <execution>
                 <goals>
@@ -438,7 +438,7 @@
           <plugin>
             <groupId>org.pitest</groupId>
             <artifactId>pitest-maven</artifactId>
-            <version>1.23.0</version>
+            <version>1.25.3</version>
             <executions>
               <execution>
                 <goals>
@@ -483,8 +483,9 @@
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-surefire-plugin</artifactId>
-            <version>3.5.5</version>
+            <version>3.5.6</version>
             <configuration>
+              <groups>deep</groups>
               <excludedGroups>benchmark,reserved</excludedGroups>
               <excludes>
                 <exclude>
@@ -731,9 +732,10 @@
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-surefire-plugin</artifactId>
-            <version>3.5.5</version>
+            <version>3.5.6</version>
             <configuration>
-              <excludedGroups>benchmark</excludedGroups>
+              <groups>reserved</groups>
+              <excludedGroups>benchmark,deep</excludedGroups>
               <excludes>
                 <exclude>
                   generated/**

src/it/lints-it/pom.xml

@@ -40,7 +40,7 @@
     <dependency>
       <groupId>com.jcabi</groupId>
       <artifactId>jcabi-xml</artifactId>
-      <version>0.35.0</version>
+      <version>0.37.0</version>
     </dependency>
     <dependency>
       <groupId>org.hamcrest</groupId>

src/it/lints-it/src/test/java/org/eolang/lints/it/FixesItTest.java

@@ -0,0 +1,48 @@
+/*
+ * SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
+ * SPDX-License-Identifier: MIT
+ */
+package org.eolang.lints.it;
+
+import com.jcabi.xml.XML;
+import com.jcabi.xml.XMLDocument;
+import java.io.IOException;
+import org.eolang.lints.Source;
+import org.hamcrest.MatcherAssert;
+import org.hamcrest.Matchers;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Integration tests for fix pipeline via {@link Source}.
+ *
+ * @since 0.2.1
+ */
+final class FixesItTest {
+
+    @Test
+    void fixesUnsortedMetas() throws IOException {
+        final XML xmir = new XMLDocument(
+            String.join(
+                "",
+                "<object>",
+                "<metas>",
+                "<meta line='1'><head>version</head><tail>0.0.0</tail></meta>",
+                "<meta line='2'><head>home</head><tail>https://www.eolang.org</tail></meta>",
+                "</metas>",
+                "</object>"
+            )
+        );
+        final Source source = new Source(xmir);
+        MatcherAssert.assertThat(
+            "unsorted-metas defect must be detected before fix",
+            source.defects().stream().anyMatch(d -> d.rule().startsWith("unsorted-metas")),
+            Matchers.is(true)
+        );
+        final XML fixed = source.fix();
+        MatcherAssert.assertThat(
+            "no unsorted-metas defect must remain after fix is applied",
+            new Source(fixed).defects().stream().noneMatch(d -> d.rule().startsWith("unsorted-metas")),
+            Matchers.is(true)
+        );
+    }
+}

src/main/java/org/eolang/lints/Fix.java

@@ -0,0 +1,24 @@
+/*
+ * SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
+ * SPDX-License-Identifier: MIT
+ */
+package org.eolang.lints;
+
+import com.jcabi.xml.XML;
+import java.io.IOException;
+
+/**
+ * A fix for a lint defect.
+ * @since 0.2.1
+ */
+@FunctionalInterface
+public interface Fix {
+
+    /**
+     * Apply the fix and return the corrected XMIR.
+     * @param xmir The XMIR to fix
+     * @return Fixed XMIR
+     * @throws IOException If something goes wrong
+     */
+    XML apply(XML xmir) throws IOException;
+}

src/main/java/org/eolang/lints/FxByXsl.java

@@ -0,0 +1,68 @@
+/*
+ * SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
+ * SPDX-License-Identifier: MIT
+ */
+package org.eolang.lints;
+
+import com.jcabi.xml.ClasspathSources;
+import com.jcabi.xml.XML;
+import com.jcabi.xml.XSL;
+import com.jcabi.xml.XSLDocument;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.util.ArrayList;
+import java.util.List;
+import org.cactoos.io.ResourceOf;
+import org.cactoos.text.IoCheckedText;
+import org.cactoos.text.TextOf;
+
+/**
+ * Fix implemented by a sequence of XSL stylesheets.
+ * @since 0.2.1
+ */
+public final class FxByXsl implements Fix {
+
+    /**
+     * XSL stylesheets to apply in order.
+     */
+    private final List<XSL> sheets;
+
+    /**
+     * Constructor.
+     * @param paths Classpath resource paths to XSL stylesheets (leading slash optional)
+     * @checkstyle ConstructorsCodeFreeCheck (5 lines)
+     */
+    public FxByXsl(final List<String> paths) {
+        this.sheets = FxByXsl.load(paths);
+    }
+
+    @Override
+    public XML apply(final XML xmir) throws IOException {
+        XML result = xmir;
+        for (final XSL sheet : this.sheets) {
+            result = sheet.transform(result);
+        }
+        return result;
+    }
+
+    private static List<XSL> load(final List<String> paths) {
+        final List<XSL> result = new ArrayList<>(paths.size());
+        for (final String path : paths) {
+            try {
+                result.add(
+                    new XSLDocument(
+                        new IoCheckedText(
+                            new TextOf(new ResourceOf(path.replaceFirst("^/", "")))
+                        ).asString()
+                    ).with(new ClasspathSources())
+                );
+            } catch (final IOException ex) {
+                throw new UncheckedIOException(
+                    String.format("Failed to load XSL stylesheet: %s", path),
+                    ex
+                );
+            }
+        }
+        return result;
+    }
+}

src/main/java/org/eolang/lints/FxEmpty.java

@@ -0,0 +1,20 @@
+/*
+ * SPDX-FileCopyrightText: Copyright (c) 2016-2026 Objectionary.com
+ * SPDX-License-Identifier: MIT
+ */
+package org.eolang.lints;
+
+import com.jcabi.xml.XML;
+
+/**
+ * A no-op fix that returns the XMIR unchanged.
+ * Used by lints that do not support auto-fixing.
+ * @since 0.2.1
+ */
+public final class FxEmpty implements Fix {
+
+    @Override
+    public XML apply(final XML xmir) {
+        return xmir;
+    }
+}