Skip to content

fix: didn't work with goheader linter #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"fmt"
"os/exec"
"path/filepath"
"strings"

"github.com/sourcegraph/jsonrpc2"
)
Expand All @@ -29,6 +30,21 @@ type langHandler struct {
noLinterName bool

rootURI string
rootDir string
}

func (h *langHandler) errToDiagnostics(err error) []Diagnostic {
var message string
switch e := err.(type) {
case *exec.ExitError:
message = string(e.Stderr)
default:
h.logger.DebugJSON("golangci-lint-langserver: errToDiagnostics message", message)
message = e.Error()
}
return []Diagnostic{
{Severity: DSError, Message: message},
}
}

func (h *langHandler) lint(uri DocumentURI) ([]Diagnostic, error) {
Expand All @@ -37,18 +53,31 @@ func (h *langHandler) lint(uri DocumentURI) ([]Diagnostic, error) {
path := uriToPath(string(uri))
dir, file := filepath.Split(path)

args := make([]string, 0, len(h.command))
args = append(args, h.command[1:]...)
args = append(args, dir)
//nolint:gosec
cmd := exec.Command(h.command[0], h.command[1:]...)
cmd.Dir = dir
cmd := exec.Command(h.command[0], args...)
if strings.HasPrefix(path, h.rootDir) {
cmd.Dir = h.rootDir
file = path[len(h.rootDir)+1:]
} else {
cmd.Dir = dir
}
h.logger.DebugJSON("golangci-lint-langserver: golingci-lint cmd", cmd)

b, err := cmd.Output()
if err == nil {
return diagnostics, nil
} else if len(b) == 0 {
// golangci-lint would output critical error to stderr rather than stdout
// https://github.com/nametake/golangci-lint-langserver/issues/24
return h.errToDiagnostics(err), nil
}

var result GolangCILintResult
if err := json.Unmarshal(b, &result); err != nil {
return diagnostics, err
return h.errToDiagnostics(err), nil
}

h.logger.DebugJSON("golangci-lint-langserver: result:", result)
Expand Down Expand Up @@ -142,6 +171,7 @@ func (h *langHandler) handleInitialize(_ context.Context, conn *jsonrpc2.Conn, r
}

h.rootURI = params.RootURI
h.rootDir = uriToPath(params.RootURI)
h.conn = conn
h.command = params.InitializationOptions.Command

Expand Down