fix: stop suppressing phone notifications on connect#91
Merged
Conversation
…n connect
Set markOnlineOnConnect: false so Baileys sends 'unavailable' presence
instead of 'available'. This prevents WhatsApp from treating the client
as an active desktop session, which was suppressing all phone push
notifications and triggering repeated "Finished syncing" notifications
on every reconnect.
Remove the explicit sendPresenceUpdate('available') call that
contradicted this setting.
Closes #90
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the WhatsApp (Baileys) connection behavior to avoid advertising a globally “available” presence on connect, which can cause WhatsApp to treat the client as an active companion session and suppress phone push notifications (per #90).
Changes:
- Pass
markOnlineOnConnect: falseintomakeWASocket()options. - Remove the explicit
sendPresenceUpdate('available')call on connection open. - Add a unit test asserting
markOnlineOnConnect: falseis provided to Baileys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/channels/whatsapp.ts |
Sets markOnlineOnConnect: false and removes the conflicting “available” presence update on connect. |
src/channels/whatsapp.test.ts |
Adds a unit test verifying the Baileys socket is created with markOnlineOnConnect: false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markOnlineOnConnect: falseinmakeWASocket()so Baileys sendsunavailablepresence on connect instead ofavailablesendPresenceUpdate('available')call that contradicted this settingmarkOnlineOnConnect: falseis passedCloses #90
Test plan
npm run build— clean compilenpm test— 288/288 pass🤖 Generated with Claude Code