fix(skill): repair /add-dashboard install after src/ refactors#2090
Closed
charlesrsimmons wants to merge 2 commits into
Closed
fix(skill): repair /add-dashboard install after src/ refactors#2090charlesrsimmons wants to merge 2 commits into
charlesrsimmons wants to merge 2 commits into
Conversation
Two compile errors surface on current main when following the SKILL.md install steps: 1. TS2307 — five imports in the pusher resource point at flat ./db/ paths for modules that have moved into ./modules/permissions/db/ (users, user_roles, user_dms, agent_group_members) and ./modules/agent-to-agent/db/ (agent_destinations). 2. TS2339 — the pusher reads g.container_config from the AgentGroup row, but that column has been removed. Container config now lives in per-group JSON files at groups/<folder>/container.json, loaded via src/container-config.ts. Update the five import paths to the new module locations. Drop the container_config field from the per-group JSON snapshot rather than wiring loadContainerConfig in — the right shape for that field is a design call best left to the maintainer once dashboard UI requirements are clear. Happy to follow up with a separate PR that wires it in. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The
/add-dashboardskill is broken on currentmain(v2.0.15). Following the SKILL.md install steps,pnpm run buildfails on the copiedsrc/dashboard-pusher.tswith two distinct compile errors.Issue 1: Imports point at non-existent paths (TS2307)
These modules existed flat under
src/db/when the skill was added (commit e9a427a, Apr 15). They were since refactored intosrc/modules/permissions/db/(users, user_roles, user_dms, agent_group_members) andsrc/modules/agent-to-agent/db/(agent_destinations).Issue 2:
agent_groups.container_configno longer exists (TS2339)The pusher reads
g.container_configfrom the AgentGroup row and JSON-parses it. That column was removed when container config moved to per-group on-disk JSON atgroups/<folder>/container.json, loaded via the newsrc/container-config.tsmodule.Fix
One file changed:
.claude/skills/add-dashboard/resources/dashboard-pusher.ts.getDestinations,getMembers,getAllUsers,getUser,getUserRoles,getAdminsOfAgentGroup,getUserDmsForUser) verified present at the new paths.container_configfield from the per-group JSON snapshot rather than wiring inloadContainerConfig(folder)fromsrc/container-config.ts.Why drop rather than rewire
container_config?Wiring the field correctly means deciding what the dashboard should show now that container config lives on disk per-group: the raw JSON, a presence flag, the resolved-with-defaults config, the path, etc. That's a design call best made by a maintainer with context on what the dashboard UI surfaces, not by a drive-by fix. Dropping the broken field is the smallest change that gets the install compiling and running today; if the dashboard renders this field anywhere, that section will show "missing" gracefully. Happy to follow up with a separate PR that wires
loadContainerConfigin once the desired shape is clear.Verification
After this fix on a fresh clone of v2.0.15:
pnpm install @nanoco/nanoclaw-dashboarddashboard-pusher.tsresource intosrc/src/index.tsper SKILL.mdpnpm run buildsucceeds (no TS2307, no TS2339)curl http://localhost:3100/api/statusreturns 200 after restartNote (out of scope)
SKILL.md step 3 ("Add exports to
src/db/index.ts") instructs adding re-exports from./agent-destinations.js— also a stale path. The current pusher imports directly from module files and doesn't consume these re-exports, so step 3 looks like dead instruction left from an earlier pusher revision. Leaving untouched here per "one thing per PR."For Skills