fix(container-runner): raise install_packages build timeout to 15min#2352
Merged
Merged
Conversation
The 5-minute timeout in buildAgentGroupImage was tight for first-time apt + pnpm global installs on slow networks (the exact scenario install_packages triggers, since the image hasn't pre-installed the requested packages). Hit ETIMEDOUT on a real install with apt + npm packages. 900_000ms gives realistic headroom without masking genuinely hung builds.
This was referenced May 9, 2026
Collaborator
|
Thanks for the contribution! Clean fix — appreciated. |
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execSynctimeout inbuildAgentGroupImage()from 5 minutes (300_000ms) to 15 minutes (900_000ms).install_packagesself-mod flow: a real install with apt + npm packages on a slow network hitspawnSync /bin/sh ETIMEDOUTmid-build, leaving the agent group's container image not rebuilt and the pending install silently abandoned.Test plan
install_packagesapproval that adds at least one apt package (e.g.ffmpeg) on a fresh image, verify build completes without ETIMEDOUT.dockerdmid-build → expect timeout after 15 min, not silent hang).🤖 Generated with Claude Code