Skip to content

fix(container-runner): raise install_packages build timeout to 15min#2352

Merged
gavrielc merged 1 commit into
nanocoai:mainfrom
Shlomog:claude/romantic-dirac-2d077b
May 9, 2026
Merged

fix(container-runner): raise install_packages build timeout to 15min#2352
gavrielc merged 1 commit into
nanocoai:mainfrom
Shlomog:claude/romantic-dirac-2d077b

Conversation

@Shlomog
Copy link
Copy Markdown

@Shlomog Shlomog commented May 8, 2026

Summary

  • Raises the execSync timeout in buildAgentGroupImage() from 5 minutes (300_000 ms) to 15 minutes (900_000 ms).
  • Surfaced via the install_packages self-mod flow: a real install with apt + npm packages on a slow network hit spawnSync /bin/sh ETIMEDOUT mid-build, leaving the agent group's container image not rebuilt and the pending install silently abandoned.
  • The previous timeout was tight specifically for first-time package installs — that's the only path that exercises this code, so the worst-case is also the common case here.

Test plan

  • Trigger an install_packages approval that adds at least one apt package (e.g. ffmpeg) on a fresh image, verify build completes without ETIMEDOUT.
  • Verify the original guard still fires for a genuinely hung build (kill dockerd mid-build → expect timeout after 15 min, not silent hang).

🤖 Generated with Claude Code

The 5-minute timeout in buildAgentGroupImage was tight for first-time
apt + pnpm global installs on slow networks (the exact scenario
install_packages triggers, since the image hasn't pre-installed the
requested packages). Hit ETIMEDOUT on a real install with apt + npm
packages.

900_000ms gives realistic headroom without masking genuinely hung builds.
@gavrielc
Copy link
Copy Markdown
Collaborator

gavrielc commented May 9, 2026

Thanks for the contribution! Clean fix — appreciated.

@gavrielc gavrielc merged commit 39e9583 into nanocoai:main May 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants