[codex] tighten codex provider contracts#2361
Draft
chiptoe-svg wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex app-serverJSON-RPC contractCODEX_MODELan optional override so Codex CLI/app-server can use its configured default when unset@openai/codexinstall contract and the container-bound auto-approval assumptionWhy
The providers branch already runs Codex through
codex app-server, but docs and examples still described parts of the older SDK and client-driven compaction design. That made the provider contract look different from the implementation and kept a stale hardcoded model default in code.Validation
cd container/agent-runner && bun test src/providers/codex.factory.test.ts src/providers/codex-app-server.test.tscd container/agent-runner && bun run typecheckpnpm run typecheckgit diff --check