-
-
Notifications
You must be signed in to change notification settings - Fork 9
Remove nanoFramework.System.Runtime dependency #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe recent update to the Changes
Sequence Diagram(s)No sequence diagrams are necessary for this change as it solely involves the removal of a package dependency without altering the control flow or introducing new features. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (7)
poc/TestOfTestFrameworkByReference/NFUnitTestByReference.nfproj
is excluded by none and included by nonepoc/TestOfTestFrameworkByReference/Test.cs
is excluded by none and included by nonepoc/TestOfTestFrameworkByReference/packages.config
is excluded by none and included by nonesource/TestFramework/CallerArgumentExpressionAttribute.cs
is excluded by none and included by nonesource/TestFramework/NullableAttributes.cs
is excluded by none and included by nonesource/TestFramework/nanoFramework.TestFramework.nfproj
is excluded by none and included by nonesource/TestFramework/packages.config
is excluded by none and included by none
Files selected for processing (1)
- source/TestFramework/packages.lock.json (1 hunks)
Files skipped from review due to trivial changes (1)
- source/TestFramework/packages.lock.json
I believe this would fix the recent error on tests on our CI: Link failure: some assembly references cannot be resolved!! |
This change will definitely fix that error. In the meantime you can downgrade the TestFramework nuget reference OR directly reference nanoFramework.System.Runtime in your test projects. |
@josesimoes :) |
Yes? 😁 If you're asking for this to be merged (and trust me, I understand the need to get this fixes asap) it still needs to be validated against mscorlib tests. The latest changes bring nice improvements, agreed. Still we need to make sure that the test framework doesn't get broken or that we lose fundamental features (such as being able to run/update tests in mscorlib) because of those. |
@josesimoes , TestFramework is actually broken right now and this PR fixes that :) |
@jazzman55 For reference there is an open discussion regarding this in Discord: https://discord.com/channels/478725473862549535/1243509599223418933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
.github/workflows/update-dependencies.yml
is excluded by none and included by nonesource/TestFramework/nanoFramework.TestFramework.nfproj
is excluded by none and included by nonesource/TestFramework/packages.config
is excluded by none and included by none
Files selected for processing (1)
- source/TestFramework/packages.lock.json (1 hunks)
Files skipped from review due to trivial changes (1)
- source/TestFramework/packages.lock.json
Description
Remove nanoFramework.System.Runtime dependency
Motivation and Context
Resolves new runtime dependency
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit
nanoFramework.System.Runtime
version 1.0.27 to streamline the package management.