Update declaration of mscorlib

[josesimoes]

Description

• Update declaration of mscorlib.

Motivation and Context

How Has This Been Tested?

• Tested against Rework Guid CoreLibrary#233

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dev Containers (changes related with Dev Containers, has no impact on code or features)
• Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

• Refactor
  • Enhanced internal operations through improved mapping and identifier management.
  • Streamlined the configuration of unique identifiers, contributing to a more consistent and efficient runtime experience.
  • Simplified the structure of the System_Guid representation by reducing the number of static fields.

[coderabbitai]

Walkthrough

This pull request updates internal mappings in the core library. In corlib_native.cpp, the method_lookup array was modified by removing five NULL entries and adding four new ones, and the assembly identifiers in g_CLR_AssemblyNative_mscorlib were updated with new hexadecimal values. In corlib_native.h, several static constant fields in the Library_corlib_native_System_Guid structure were removed, one field’s value was updated, and a new field was added.

Changes

File(s)	Change Summary
src/CLR/CorLib/.../corlib_native.cpp	Modified method_lookup array (removed 5 NULL entries, added 4 NULL entries) and updated assembly identifiers from 0xE76AC236→0x6386D1B4 and 0xA0E4A156→0xA145623D.
src/CLR/CorLib/.../corlib_native.h	Removed multiple static constant fields (FIELD___a to FIELD___k), updated FIELD_STATIC__Empty from 10 to 14, and added the new field FIELD___data with value 1.

Possibly related PRs

• Rework DateTime and TimeSpan #3084: Addresses similar modifications in g_CLR_AssemblyNative_mscorlib and the method_lookup array.
• Update mscorlib assembly declarations #3070: Involves comparable updates to the method_lookup array and assembly identifiers in corlib_native.cpp.

Suggested labels

Area: Common libs

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e923cbe and 97d3d09.

📒 Files selected for processing (2)

• src/CLR/CorLib/corlib_native.cpp (3 hunks)
• src/CLR/CorLib/corlib_native.h (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• src/CLR/CorLib/corlib_native.cpp
• src/CLR/CorLib/corlib_native.h

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: nf-interpreter (Check_Code_Style)
• GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ST_NUCLEO64_F091RC)
• GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ORGPAL_PALX)
• GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ORGPAL_PALTHREE)
• GitHub Check: nf-interpreter (Nightly build) (Check_Build_Options)
• GitHub Check: nf-interpreter (Check_Build_Options)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.