chore: Spec CompliantDataFrame
#2223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Variance of `CompliantSeriesT_co` changed due to how it is used - Made a lot of the types more generic - They can be refined by the implementations - Some will handle coverting to narrower types, where that backend demands it - **Main missing part** is `CompliantExpr` - Need to spec `CompliantSeries` first - Otherwise, introduces lots of errors for `Polars*`
- Technically works, but I'd like to avoid the `Any` - Maybe adding a generic callable alias, that gets subscribed w/ `Self`?
- Have a feeling this was used more in the past - E.g. when `select` accepted `*args, **kwds`
9 tasks
`nw.DataFrame` already calls with keyword
dangotbanned
commented
Mar 16, 2025
There was a problem hiding this comment.
thanks @dangotbanned !
just got a comment on the aggregate comment
dangotbanned
commented
Mar 16, 2025
dangotbanned
commented
Mar 16, 2025
- Resolves #2223 (comment) - Will help with `EagerDataFrame` as well
- `filter` accepts a `list` in some cases - `group_by` will need `CompliantGroupBy` - See also #2184 (comment)
- Now we don't accept any arbitrary expression - It must derive the current type - Simplifies the typing - Really wasn't happy with what I had previously - Glad that is gone now - Added a doc, since the single output part is really the most important
dangotbanned
commented
Mar 16, 2025
Seems to not interact well with `.collect()`? #2223 (comment)
dangotbanned
commented
Mar 16, 2025
Thanks @MarcoGorelli! What's your question? |
|
Sorry it got lost 😃 just left it as a comment |
dangotbanned
commented
Mar 16, 2025
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
CompliantNamespaceprotocol #2202CompliantExpr#2119CompliantSelector#2064Checklist
If you have comments or can explain your changes, please do so below
PolarsDataFrame.__getattr__annotationsCompliantDataFrame.aggregate(4dc0514)FBT001) issues (70cc069)CompliantExprinCompliantDataFrame