Skip to content

Testing with configured fixed-size types #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LeStarch merged 5 commits into from
Mar 28, 2025
Merged

Testing with configured fixed-size types #3409

LeStarch merged 5 commits into from
Mar 28, 2025

Conversation

@LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Mar 25, 2025

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Fixes issues using configured fixed-size types!

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 25, 2025
View reviewed changes
Svc/ComQueue/ComQueue.cpp
const FwIndexType portNum = queueNum - ((queueType == QueueType::COM_QUEUE) ? 0 : COM_PORT_COUNT);
FW_ASSERT((queueType == QueueType::COM_QUEUE) || (queueNum >= COM_PORT_COUNT),
static_cast<FwAssertArgType>(queueType), static_cast<FwAssertArgType>(queueNum));
const FwIndexType portNum = static_cast<FwIndexType>(queueNum - ((queueType == QueueType::COM_QUEUE) ? 0 : COM_PORT_COUNT));

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter queueNum has not been checked.
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 25, 2025
View reviewed changes
Os/Queue.cpp
QueueInterface::Status Queue::send(const U8* buffer,
FwSizeType size,
PlatformIntType priority,
FwQueuePriorityType priority,

Check notice

Code scanning / CodeQL

Use of basic integral type Note

priority uses the basic integral type unsigned char rather than a typedef with size and signedness.
Os/Queue.cpp
QueueInterface::BlockingType blockType,
FwSizeType& actualSize,
PlatformIntType& priority) {
FwQueuePriorityType& priority) {

Check notice

Code scanning / CodeQL

Use of basic integral type Note

priority uses the basic integral type unsigned char rather than a typedef with size and signedness.
Os/Queue.cpp

QueueInterface::Status Queue::send(const Fw::SerializeBufferBase& message,
PlatformIntType priority,
FwQueuePriorityType priority,

Check notice

Code scanning / CodeQL

Use of basic integral type Note

priority uses the basic integral type unsigned char rather than a typedef with size and signedness.
Os/Queue.cpp
QueueInterface::Status Queue::receive(Fw::SerializeBufferBase& destination,
QueueInterface::BlockingType blockType,
PlatformIntType& priority) {
FwQueuePriorityType& priority) {

Check notice

Code scanning / CodeQL

Use of basic integral type Note

priority uses the basic integral type unsigned char rather than a typedef with size and signedness.
Svc/ComQueue/ComQueue.cpp
void ComQueue::buffQueueIn_handler(const FwIndexType portNum, Fw::Buffer& fwBuffer) {
const FwIndexType queueNum = portNum + COM_PORT_COUNT;
FW_ASSERT(std::numeric_limits<FwIndexType>::max() - COM_PORT_COUNT > portNum);
const FwIndexType queueNum = static_cast<FwIndexType>(portNum + COM_PORT_COUNT);

Check notice

Code scanning / CodeQL

Use of basic integral type Note

queueNum uses the basic integral type signed short rather than a typedef with size and signedness.
Svc/ComQueue/ComQueue.cpp
const FwIndexType portNum = queueNum - ((queueType == QueueType::COM_QUEUE) ? 0 : COM_PORT_COUNT);
FW_ASSERT((queueType == QueueType::COM_QUEUE) || (queueNum >= COM_PORT_COUNT),
static_cast<FwAssertArgType>(queueType), static_cast<FwAssertArgType>(queueNum));
const FwIndexType portNum = static_cast<FwIndexType>(queueNum - ((queueType == QueueType::COM_QUEUE) ? 0 : COM_PORT_COUNT));

Check notice

Code scanning / CodeQL

Use of basic integral type Note

portNum uses the basic integral type signed short rather than a typedef with size and signedness.
config/DpCatalogCfg.hpp
// this size.
static const FwSizeType DP_MAX_DIRECTORIES = 2;
static const FwSizeType DP_MAX_FILES = 1000;
static const FwIndexType DP_MAX_DIRECTORIES = 2;

Check notice

Code scanning / CodeQL

Use of basic integral type Note

DP_MAX_DIRECTORIES uses the basic integral type signed short rather than a typedef with size and signedness.
config/DpCatalogCfg.hpp
static const FwSizeType DP_MAX_DIRECTORIES = 2;
static const FwSizeType DP_MAX_FILES = 1000;
static const FwIndexType DP_MAX_DIRECTORIES = 2;
static const FwIndexType DP_MAX_FILES = 127;

Check notice

Code scanning / CodeQL

Use of basic integral type Note

DP_MAX_FILES uses the basic integral type signed short rather than a typedef with size and signedness.
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 25, 2025
View reviewed changes
Svc/DpCatalog/DpCatalog.cpp

// extract metadata for each file
for (FwNativeUIntType file = 0; file < filesRead; file++) {
for (FwSizeType file = 0; file < filesRead; file++) {

Check notice

Code scanning / CodeQL

Use of basic integral type Note

file uses the basic integral type unsigned long rather than a typedef with size and signedness.
kevin-f-ortega
kevin-f-ortega approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@kevin-f-ortega kevin-f-ortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only comment is to use PlatformTaskPriorityType in the OSAL::Task code. That is captured here #3410 and will be addressed in a future PR. This is good for now.

@kevin-f-ortega kevin-f-ortega mentioned this pull request Mar 26, 2025
Closed
@LeStarch LeStarch merged commit 2dcd219 into nasa:devel Mar 28, 2025
41 checks passed
thomas-bc pushed a commit to thomas-bc/fprime that referenced this pull request Apr 8, 2025
@LeStarch @thomas-bc
Testing with configured fixed-size types (nasa#3409)
a098b02 
* Testing with configured fixed-size types

* Linux fixes

* Final settings

* Removing FwNativeIntType
@LeStarch LeStarch deleted the issue-3208-fixed-ints branch August 19, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin-f-ortega kevin-f-ortega kevin-f-ortega approved these changes

@thomas-bc thomas-bc thomas-bc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeStarch @kevin-f-ortega @thomas-bc