Config blank slate #3487
Merged
Config blank slate #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
force-pushed
the
config-blank-slate
branch
from
32b8959 to
b25daf5
Compare
thomas-bc
reviewed
Apr 16, 2025
Collaborator
thomas-bc
left a comment
thomas-bc
left a comment
There was a problem hiding this comment.
Need to update comments to functions that have changed
thomas-bc
reviewed
Apr 16, 2025
Collaborator
thomas-bc
left a comment
thomas-bc
left a comment
There was a problem hiding this comment.
What happens in the case of a build dependency that is not a link dependency, and does it need to be added to the recursive call?
Collaborator
Author
|
Another issue to add is checking that deployments have UTs. |
LeStarch
force-pushed
the
config-blank-slate
branch
from
5bdb401 to
4b98dc7
Compare
LeStarch
added
the
Breaking Changes / Needs Release Notes
Collaborator
Author
Breaking Change Report
Recommended Changes
|
thomas-bc
reviewed
Apr 17, 2025
Collaborator
thomas-bc
left a comment
thomas-bc
left a comment
There was a problem hiding this comment.
A couple of comments / thoughts, but overall this looks great !
thomas-bc
approved these changes
Apr 17, 2025
thomas-bc
pushed a commit
to fprime-community/fprime-tutorial-math-component
that referenced
this pull request
Apr 17, 2025
thomas-bc
pushed a commit
to fprime-community/fprime-system-reference
that referenced
this pull request
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
CMake refactor - pt1