Fix ISR handler invocation in Drv::BlockDriver #3586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
approved these changes
May 12, 2025
Collaborator
LeStarch
left a comment
LeStarch
left a comment
There was a problem hiding this comment.
Looks right to me. I am going to have a few more people look into it. Thanks for the UTs too!
kevin-f-ortega
approved these changes
May 12, 2025
Collaborator
kevin-f-ortega
left a comment
kevin-f-ortega
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for the fix and adding unit tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Use InterruptReport_internalInterfaceInvoke to handle the ISR according to the issue description.
Added some nominal unit tests for data loop back and for ISR.
Rationale
Fix #3235.
Testing/Review Recommendations
N/A.
Future Work
Fix TBD in chapter 4. Dictionaries in SDD. Please share the intention of this chapter - I'll fix it.