Removing regneration from AC files that are themselves regenerated #3602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Prevents
GENERATEDsource files from being marked asCMAKE_CONFIGURE_DEPENDSinrequires_regenerationinstead of depending on caller's good graces.Rationale
Marking source files as
CMAKE_CONFIGURE_DEPENDSthat are alsoGENERATEDcan cause loops within the build/configure steps (build depends on configure, which via this property is dependent on build output).This removes the responsibility of the caller to track if a file was GENERATED, and instead queries CMake for that data instead. Thus preventing caller error from causing regeneration cycles.