Array toString() delimited with comma #3626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
FPP v3.0.0a11 with the FPP change is available: https://github.com/nasa/fpp/actions. |
bocchino
approved these changes
May 21, 2025
Collaborator
bocchino
left a comment
bocchino
left a comment
There was a problem hiding this comment.
Looks good! Ready to merge after the FPP version is updated and CI passes.
LeStarch
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
There was an inconsistency in the way we format arrays between struct member arrays and array types. Array types did not delimit elements with a comma and a space while struct member arrays did.
We decided in nasa/fpp#712 to add the comma in array
toString(). This PR updates FPPTest with this changeThis PR depends on nasa/fpp#716