Skip to content

Conversation

@m-aleem
Copy link
Contributor

@m-aleem m-aleem commented May 30, 2025

Related Issue(s) #3446
Has Unit Tests (y/n) Yes - existing
Documentation Included (y/n) N/A

Change Description

Updates to multiple directories fprime/Fw/*to change:

  • PRIVATE -> private
  • PROTECTED -> protected
  • Add friend classes, as needed

Rationale

#3446

Testing/Review Recommendations

N/A

Future Work

Additional PRs to be opened for further updates corresponding to #3446

@m-aleem m-aleem requested a review from thomas-bc May 30, 2025 00:05
@m-aleem m-aleem marked this pull request as ready for review May 30, 2025 00:06
@m-aleem
Copy link
Contributor Author

m-aleem commented Jun 2, 2025

@LeStarch I think error message for the failing automated check is indicating an issue in the workflow itself and how it is treating requirements.txt (i.e. not in my updated files). Is there a point of contact for this that can take a look/help re-run as needed?

@LeStarch
Copy link
Collaborator

LeStarch commented Jun 2, 2025

I have asked @thomas-bc to fix this, as there is a known fix for this.

@LeStarch LeStarch merged commit 8ead55a into nasa:devel Jun 2, 2025
47 checks passed
@m-aleem m-aleem deleted the devel-3446-h branch June 2, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants