FpySequencer floating point comparisons #3820
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| //! Internal interface handler for directive_setSerReg | ||
| Signal FpySequencer::setSerReg_directiveHandler(const FpySequencer_SetSerRegDirective& directive, DirectiveError& error) { | ||
| Signal FpySequencer::setSerReg_directiveHandler(const FpySequencer_SetSerRegDirective& directive, |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| } | ||
|
|
||
| Signal FpySequencer::deserSerReg_directiveHandler(const FpySequencer_DeserSerRegDirective& directive, DirectiveError& error) { | ||
| Signal FpySequencer::deserSerReg_directiveHandler(const FpySequencer_DeserSerRegDirective& directive, |
Check notice
Code scanning / CodeQL
Long function without assertion Note
|
|
||
| Signal FpySequencer::binaryCmp_directiveHandler(const FpySequencer_BinaryCmpDirective& directive, DirectiveError& error) { | ||
|
|
||
| Signal FpySequencer::binaryCmp_directiveHandler(const FpySequencer_BinaryCmpDirective& directive, |
Check notice
Code scanning / CodeQL
Long function without assertion Note
|
|
||
| Signal FpySequencer::binaryCmp_directiveHandler(const FpySequencer_BinaryCmpDirective& directive, DirectiveError& error) { | ||
|
|
||
| Signal FpySequencer::binaryCmp_directiveHandler(const FpySequencer_BinaryCmpDirective& directive, |
Check notice
Code scanning / CodeQL
Function too long Note
|
@LeStarch looks like it's failing CI due to some nondeterminism, can you take a look? |
LeStarch
left a comment
LeStarch
left a comment
There was a problem hiding this comment.
In general it looks good, but I did wonder about some things.
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@LeStarch this PR is WIP, missing a couple UTs |
|
@LeStarch this PR is ready for review again, I think it's good to go as well. code is much cleaner now |
LeStarch
left a comment
LeStarch
left a comment
There was a problem hiding this comment.
Much, MUCH easier to review. Thanks!
2 participants
Change Description
Adds floating point <, >, <=, >=, == and != operators.
Rationale
Users of Fpy need to be able to compare floating point values, not just integers.