Skip to content

Conversation

@m-aleem
Copy link
Contributor

@m-aleem m-aleem commented Jun 27, 2025

Related Issue(s) #3446
Has Unit Tests (y/n) Yes - existing
Documentation Included (y/n) N/A

Change Description

Finally remove the PROTECTED, PRIVATE, and STATIC macro overrides!

Rationale

#3446

@m-aleem m-aleem marked this pull request as ready for review July 10, 2025 05:31
@LeStarch LeStarch added this to the Release v4.0.0a2 milestone Jul 23, 2025
@m-aleem
Copy link
Contributor Author

m-aleem commented Jul 23, 2025

External repos which need updates:

--

Local testing notes:

Update .gitmodules to point to this branch:

[submodule "fprime"]
	path = fprime
	url = https://github.com/m-aleem/fprime.git
	branch = devel-3446-aq

git submodule update --init --recursive && git submodule update --remote
fprime-util generate --ut -f && fprime-util check

@thomas-bc
Copy link
Collaborator

Closing and re-opening for CI

@thomas-bc thomas-bc closed this Jul 23, 2025
@thomas-bc thomas-bc reopened this Jul 23, 2025
@m-aleem
Copy link
Contributor Author

m-aleem commented Jul 23, 2025

Closing and re-opening for CI

@m-aleem m-aleem closed this Jul 23, 2025
@m-aleem m-aleem reopened this Jul 23, 2025
@m-aleem
Copy link
Contributor Author

m-aleem commented Jul 23, 2025

Closing and re-opening for CI

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀 💯

thomas-bc pushed a commit to fprime-community/fprime-tutorial-hello-world that referenced this pull request Jul 23, 2025
thomas-bc pushed a commit to fprime-community/fprime-tutorial-math-component that referenced this pull request Jul 23, 2025
thomas-bc pushed a commit to fprime-community/fprime-workshop-led-blinker that referenced this pull request Jul 23, 2025
thomas-bc pushed a commit to fprime-community/fprime-system-reference that referenced this pull request Jul 23, 2025
thomas-bc pushed a commit to nasa/fprime-examples that referenced this pull request Jul 23, 2025
@thomas-bc thomas-bc merged commit 65355c5 into nasa:devel Jul 23, 2025
365 of 418 checks passed
@m-aleem m-aleem deleted the devel-3446-aq branch July 23, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants