Linux should not default to stubbed drivers #3840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuynh4duarte
approved these changes
Jul 3, 2025
Contributor
chuynh4duarte
left a comment
chuynh4duarte
left a comment
There was a problem hiding this comment.
fixed status return "Failed to open GPIO pin: 7" in fprime-workshop-led-blinker
LeStarch
force-pushed
the
LeStarch-patch-1
branch
2 times, most recently
from
9b3bd87 to
cade0a7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // write data | ||
| stat = static_cast<int>(write(this->m_fd, serBuffer.getData(), static_cast<size_t>(serBuffer.getSize()))); | ||
| if (stat == -1) { | ||
| ssize_t status_write = write(this->m_fd, serBuffer.getData(), static_cast<size_t>(serBuffer.getSize())); |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
| stat = static_cast<int>(read(this->m_fd, serBuffer.getData(), serBuffer.getSize())); | ||
| if (stat == -1) { | ||
| FW_ASSERT_NO_OVERFLOW(serBuffer.getSize(), size_t); | ||
| ssize_t status_read = read(this->m_fd, serBuffer.getData(), static_cast<size_t>(serBuffer.getSize())); |
Check notice
Code scanning / CodeQL
Use of basic integral type Note
kevin-f-ortega
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Linux should not default to stubbed drivers. This was a regression.