Skip to content

Conversation

@LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Jul 9, 2025

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Just bumping to fprime-tools v4.0.0a4 to ensure backwards compatibility.

@LeStarch LeStarch changed the title Bump to fprime-tools v4.0.0a4 Bump to fprime-tools v4.0.0a5 Jul 9, 2025
@LeStarch LeStarch closed this Jul 9, 2025
@LeStarch LeStarch reopened this Jul 9, 2025
@LeStarch LeStarch changed the title Bump to fprime-tools v4.0.0a5 Bump to fprime-tools v4.0.0a6 (Fix CI) Jul 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI integration to allow selecting a specific platform directory when running tests and applies it for the Raspberry Pi target.

  • Added an optional PLATFORM parameter to integration_test_run (default *)
  • Updated the fprime-gds dictionary path to use the new PLATFORM variable
  • Modified RPI-Ints.bash to invoke integration_test_run with "raspberrypi"

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
ci/tests/fputil.bash Export PLATFORM and inject it into the fprime-gds dictionary path
ci/tests/RPI-Ints.bash Pass "raspberrypi" as the second argument when calling integration_test_run
Comments suppressed due to low confidence (1)

ci/tests/fputil.bash:62

  • [nitpick] Add a brief header comment explaining the optional second PLATFORM parameter, its default (*), and how it affects the dictionary lookup to improve clarity for future maintainers.
function integration_test_run {

kevin-f-ortega
kevin-f-ortega previously approved these changes Jul 11, 2025
Copy link
Collaborator

@kevin-f-ortega kevin-f-ortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @LeStarch !

@LeStarch
Copy link
Collaborator Author

Diagnosis: the RPI tests failed because the new system includes both the deployment build and the unit-tests when building a deployment. This is likely the preferred behavior, however; it does mean that the UTs built including the deployment resulting in both Linux and raspberrypi being installed.

This meant that we required a unique identifier and not *

@LeStarch
Copy link
Collaborator Author

@kevin-f-ortega please review and if you approve, merge this one. Should fix CI.

@kevin-f-ortega kevin-f-ortega merged commit 5241239 into devel Jul 15, 2025
93 checks passed
@kevin-f-ortega kevin-f-ortega deleted the LeStarch-patch-2 branch July 15, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants