-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Bump to fprime-tools v4.0.0a6 (Fix CI) #3863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI integration to allow selecting a specific platform directory when running tests and applies it for the Raspberry Pi target.
- Added an optional
PLATFORMparameter tointegration_test_run(default*) - Updated the
fprime-gdsdictionary path to use the newPLATFORMvariable - Modified
RPI-Ints.bashto invokeintegration_test_runwith"raspberrypi"
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ci/tests/fputil.bash | Export PLATFORM and inject it into the fprime-gds dictionary path |
| ci/tests/RPI-Ints.bash | Pass "raspberrypi" as the second argument when calling integration_test_run |
Comments suppressed due to low confidence (1)
ci/tests/fputil.bash:62
- [nitpick] Add a brief header comment explaining the optional second
PLATFORMparameter, its default (*), and how it affects the dictionary lookup to improve clarity for future maintainers.
function integration_test_run {
kevin-f-ortega
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @LeStarch !
c1f1882 to
2432850
Compare
|
Diagnosis: the RPI tests failed because the new system includes both the deployment build and the unit-tests when building a deployment. This is likely the preferred behavior, however; it does mean that the UTs built including the deployment resulting in both This meant that we required a unique identifier and not |
|
@kevin-f-ortega please review and if you approve, merge this one. Should fix CI. |
2432850 to
f86a765
Compare
Change Description
Just bumping to fprime-tools v4.0.0a4 to ensure backwards compatibility.