Skip to content

Conversation

@m1r0n41k
Copy link
Contributor

@m1r0n41k m1r0n41k commented Sep 4, 2017

It's work only if I update display orientation before call start()

@natario1
Copy link
Owner

natario1 commented Sep 5, 2017

Cool! I guess that's because onAttachedToWindow might be called late. Can you do a little change, change OrientationHelper enable method to accept just a Context and get the display from there?

So in CameraView class you will only call mOrentationHelper.enable(getContext()).

About the travis build failing, I think that's a problem from my side, I will fix it.

Repository owner deleted a comment from codecov bot Sep 5, 2017
@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 0%.

Impacted Files Coverage Δ
...ain/java/com/otaliastudios/cameraview/Camera1.java 0% <0%> (ø) ⬆️
...om/otaliastudios/cameraview/OrientationHelper.java 30% <0%> (ø) ⬆️
.../java/com/otaliastudios/cameraview/CameraView.java 35% <0%> (ø) ⬆️

Repository owner deleted a comment from codecov bot Sep 5, 2017
@natario1
Copy link
Owner

natario1 commented Sep 5, 2017

Great @m1r0n41k , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants