Fix to the bug #518 #519
Merged
natemcmaster merged 2 commits intonatemcmaster:mainfrom Nov 19, 2022
ernstc:main
Merged
Conversation
…ty. This fixes the bug #518
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
==========================================
+ Coverage 82.28% 82.30% +0.02%
==========================================
Files 106 106
Lines 3302 3306 +4
==========================================
+ Hits 2717 2721 +4
Misses 585 585
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Owner
|
Thanks for sending a PR. Would you mind adding a test case? It looks like you basically wrote them in the issue description of #518 |
…fix to the issue #518.
Contributor
Author
|
Hi @natemcmaster, I have added the tests relative to the issue. |
Owner
|
Thanks @ernstc ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check on the model type before it proceeds accessing the property with its getter or setter.
The exception is thrown because it tries to get the value of a property defined on a different type.
Given two commands A and B, where B is sub command of A, bot commands define an argument property. In this case it tries to get the value of the argument property defined in A from the model of type B. This thows the exception described in the bug #518.