refactor: replace cli-color with picocolors#256
refactor: replace cli-color with picocolors#256nathanhleung merged 3 commits intonathanhleung:masterfrom JounQin:refactor/replace_cli-color
cli-color with picocolors#256Conversation
|
Does anything but Kaspersky report it as a virus? The comments and links on that issue suggest that any antivirus company controllable by a hostile nation-state shouldn't be trusted, which includes Kaspersky. |
|
@ljharb I noticed this issue via https://github.com/apps/socket-security. By the way, |
|
Unfortunately picocolors does not declare an engines field; does it support node 8+? |
https://app.unpkg.com/picocolors@1.1.1/files/picocolors.js I think Node 6+ is supported, only |
|
I don't think the CI broken is related to this PR: Run npm install -g pnpm@3 yarn@1
npm WARN notice [SECURITY] pnpm has the following vulnerabilities: 2 high, 1 moderate. Go here for more details: https://github.com/advisories?query=pnpm - Run `npm i npm@latest -g` to upgrade your npm version, and then `npm audit` to get more info.
npm ERR! path C:\npm\prefix\yarn.cmd
npm ERR! code EEXIST
npm ERR! Refusing to delete C:\npm\prefix\yarn.cmd: is outside C:\npm\prefix\node_modules\yarn and not a link
npm ERR! File exists: C:\npm\prefix\yarn.cmd
npm ERR! Move it away, and try again.
npm ERR! A complete log of this run can be found in:
npm ERR! C:\npm\cache\_logs\2025-0[4](https://github.com/nathanhleung/install-peerdeps/actions/runs/14250611119/job/39943052401?pr=256#step:6:5)-03T19_10_31_722Z-debug.log |
|
I agree, but it passed 2 weeks ago, so I'm not sure what the issue is. It'll have to wait until that's resolved. |
@ljharb Maybe just retry failed workflows? I noticed that Windows + Node 8/10/12+ all works. |
|
That doesn't seem to do it. |
|
@ljharb Maybe |
|
@nathanhleung Just tried |
|
@JounQin approved your workflow |
|
Sadly it doesn't work, I'll revert back. |
|
@nathanhleung So are we good to merge with the two known broken workflows? |
|
Friendly ping @nathanhleung |
@JounQin thanks, merged and will cut a new release shortly. |
|
Released in v3.0.7 |
cli-color->es5-extdetected as a virusmedikoo/es5-ext#186