Handle ranges of peer dependencies#4
Merged
nathanhleung merged 3 commits intonathanhleung:masterfrom Mar 7, 2017
Merged
Conversation
added 2 commits
March 5, 2017 21:49
If a peer dependency is '^3.0.2 || ^4.0.0', just install the first mentioned comparator. i.e. '^3.0.2'
Owner
|
Thanks for the pull! It looks good to me, but for future pulls I want to set up CI and tests, so just hang tight while I put that together. |
Owner
|
I added another commit to the pull to get the linting to pass and made one variable a little more clear — thanks again for your contribution! |
Contributor
Author
|
@nathanhleung Great! Thanks for this tool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
mentions that it will run:
eslint-plugin-jsx-a11y@^3.0.2 || ^4.0.0is problematic here, and the following error occurs:Solution
If a peer dependency is a range like
^3.0.2 || ^4.0.0, just install the last mentioned comparator. i.e.^4.0.0.This also works for ranges specified as
>=1.2.7 <1.3.0.