Fix installation not starting after package manager confirmation.#66
Merged
nathanhleung merged 2 commits intonathanhleung:masterfrom Apr 10, 2020
Merged
Fix installation not starting after package manager confirmation.#66nathanhleung merged 2 commits intonathanhleung:masterfrom
nathanhleung merged 2 commits intonathanhleung:masterfrom
Conversation
Contributor
Author
|
I believe that failing test is due to the action not having privileges for the env variables; but let me know if you think otherwise. |
Collaborator
|
@nathanhleung PRs from forks can't ever access secrets, so any CI that depends on encrypted env vars will always fail on PRs from forks (ie, from anyone who's not a collaborator). |
|
@nathanhleung are you good with this? The yarn check is currently bailing out, meaning packageManager has to be explicitly defined. |
|
Experienced the same issue reported originally in #70. This very much deserves a merge. |
Owner
|
Sorry for the delay -- this was buried in my GitHub notifications! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Behaviour
After receiving confirmation from the user that they would like to use yarn as their package manager, the script proceeds to install peer dependencies with yarn.
Current Behaviour
After receiving confirmation to use yarn, the script exits without installation.
Fix
Updated the implementation of promptly's confirm function to use a promise instead of a callback.