bugfix & chaining for maxPartSize and concurrentParts #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow nice catch... Thanks for this! |
nathanpeck
added a commit
that referenced
this pull request
Aug 15, 2014
Bugfix & chaining for maxPartSize and concurrentParts
nathanpeck
added a commit
that referenced
this pull request
Aug 15, 2014
|
Okay v0.6.0 is now published on NPM. Enjoy! |
|
Awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
The README seemed incorrect in that maxPartSize and concurrentParts appear to be calls on the uploadStreamObject and not the uploadStream as documented.
In adjusting the README I found you couldn't chain the calls which seems to be a desirable pattern so I tweaked the return values from the functions as well.
(great library - will be extremely useful - thanks!)