Skip to content

[FIXED] Use default timeout for ObjectStore.Get when no deadline is set on ctx #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Apr 9, 2025

Fixes #1848

Signed-off-by: Piotr Piotrowski [email protected]

@piotrpio piotrpio requested a review from Jarema April 9, 2025 11:27
@piotrpio piotrpio force-pushed the fix-goroutine-leak branch from a3de24f to 827de14 Compare April 9, 2025 11:33
@coveralls
Copy link

Coverage Status

coverage: 84.731% (+0.04%) from 84.689%
when pulling 827de14 on fix-goroutine-leak
into 8a2bd73 on main.

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit e04728e into main Apr 9, 2025
6 checks passed
@piotrpio piotrpio deleted the fix-goroutine-leak branch April 9, 2025 13:56
@piotrpio piotrpio mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goroutine and consumer leak on jetstream's ObjectStore.Get with timeoutless context when the server is unresponsive
3 participants