Allow zero commission for PerContractFeeModel #2282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
I would like to enable setting zero commistion during backtest.
There are 4 reasonable use cases:
Of course, everyone should use realistic commissions for final testing, but setting up zero commission if user intentionally wants that for specific use-case, that should not be blocked.
Type of change
Note: this just extends possibilities to use zero commission if needed and does not block anything.